Skip to content

refactor(desktop): establish shared contract foundation#349

Merged
Whiteks1 merged 1 commit intomainfrom
codex/desktop-shared-workspace-contract
Apr 10, 2026
Merged

refactor(desktop): establish shared contract foundation#349
Whiteks1 merged 1 commit intomainfrom
codex/desktop-shared-workspace-contract

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

@Whiteks1 Whiteks1 commented Apr 10, 2026

Summary

  • Establish the first shared Desktop contract layer under desktop/shared.
  • Type the existing workspace, runtime or snapshot, and smoke boundaries via narrow JSDoc without changing runtime behavior.

Issue

  • N/A. This foundation slice predates the migration issue block and does not close a tracked GitHub issue.

Why

  • The desktop needed a first real shared contract boundary before introducing the larger TypeScript base slice.
  • This reduces drift between main, preload, renderer, and smoke without opening renderer or architecture work early.

Scope

This PR does not:

  • Add unrelated feature work.
  • Expand scope beyond the slice.
  • Introduce a second source of truth for the same content or behavior.

Validation

Validated with:

  • node --check main.js
  • node --check preload.js
  • node --check renderer/app.js
  • node --check scripts/smoke.js
  • npm run smoke:fallback
  • npm run smoke:real-path

Duplication Check

  • I searched for existing docs, surfaces, or contracts covering the same idea.
  • I removed or replaced stale copies instead of keeping both versions.
  • I did not introduce alternate lockfiles, package managers, or build paths.

Compatibility / Risk

  • No compatibility change intended; this is a narrow contract-typing slice.
  • Risk is limited to JSDoc typing drift in the existing JS files.

Notes

  • This PR only aligns contracts and narrow type consumption.
  • It prepares the follow-up TypeScript base slice and does not change visible desktop behavior.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Whiteks1, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@Whiteks1 Whiteks1 merged commit 9b0474b into main Apr 10, 2026
3 checks passed
@Whiteks1 Whiteks1 deleted the codex/desktop-shared-workspace-contract branch April 10, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant