fix(desktop): restore Runs table width bounds to avoid flex/grid squash#341
Merged
fix(desktop): restore Runs table width bounds to avoid flex/grid squash#341
Conversation
…ping of the Window dates column
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When grouping the 'Trades' text inline with the 'Window' timeframe (\2022-01-01 -> 2023-12-31), it was wrapped in a nested grid .run-primary-meta. This, combined with the new 4th \Compare\ button expanding the action column, caused the CSS Grid engine to incorrectly squash the <td>\ column width down to zero. The mono-cell text was violently wrapping.
Fixed by replacing the inner grid with simple stack alignment (\ lex-direction: column) and strictly setting \white-space: nowrap\ so the dates maintain horizontal stability.