Clean up README typo/comments and remove dead debug code#79
Open
yuegchen wants to merge 1 commit into
Open
Conversation
- README: fix 'pefilling' -> 'prefilling' typo - README: complete truncated layers/ and utils/ structure comments - qwen3.py: remove leftover DEBUG comment and unused 'import sys' in Qwen3Attention.forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small cleanup PR — documentation fixes plus removal of leftover debug code. No behavioral changes.
Changes
pefilling→prefilling(the heading for thebenchmark_prefilling.pysection; the line just below already says "prefilling phase").# Components for model/,# context), describing what actually lives inlayers/andutils/.src/myvllm/models/qwen3.py: remove a leftover# DEBUGcomment and an unusedimport sysinsideQwen3Attention.forward(also drops a trailing whitespace on the following line).All changes are verifiable by reading; no runtime/GPU needed.