Annie Kong's Story Map Project#33
Annie Kong's Story Map Project#33xiaomkk wants to merge 1 commit intoWeitzman-MUSA-JavaScript:mainfrom
Conversation
mjumbewu
left a comment
There was a problem hiding this comment.
Generally, nice work on this -- it has a really nice visual style. I made a few additional comments below.
There was a problem hiding this comment.
suggestion: This file is about 1.5MB. It's on the edge of being too large for what I'd recommend for a public-facing app. There are a number of things you could do to make it smaller, such as remove fields you're not using, and reducing the precision of the coordinates (right now you're using 15 digits of precision, which is default in many GIS platforms; however seven decimal places corresponds to about a centimeter of precision in the real world: https://wiki.openstreetmap.org/wiki/Precision_of_coordinates)
| const io = new IntersectionObserver((entries) => { | ||
| entries.forEach(e => { | ||
| if (e.isIntersecting) { | ||
| const newIdx = slides.indexOf(e.target); | ||
| if (newIdx !== idx) { | ||
| idx = newIdx; | ||
| slides.forEach((s, j) => s.classList.toggle('active', j === idx)); | ||
| activateLayers(slides[idx]); | ||
| updateDots(); | ||
| } | ||
| } | ||
| }); | ||
| }, {threshold: 0.6}); |
There was a problem hiding this comment.
question: Interesting (and correct) use of InteractionObserver. Out of curiosity, where did you find this pattern?
| <section class="slide" data-step="2" data-layer="pools" data-center="39.94,-75.16" data-zoom="12.2"> | ||
| <div class="content"> | ||
| <h2>Swimming pools</h2> | ||
| <p>Public pools provide seasonal relief on extreme heat days.</p> |
There was a problem hiding this comment.
suggestion: I would love to see more information in this slide content (and all the slides). There's so much more that can be (and has been) said about heat relief measures.
Ultimately this is a question of user need. Who are the intended users for this map? If it's residents, then perhaps explaining pool access schedules, and maybe things they should keep in mind when looking to access pools might be good to include. If it's a general educational tool (e.g. journalistic), then perhaps some of the history of pool access, closures, etc.
This maps involves with creating a scrolling Story Map that allows users to learn about heat vulnerability in Philadelphia. And use the scroll function on their devices to explore cooling locations in Philadelphia. The purpose of this story map is to guide users who are not familiar with cooling locations in Philadelphia, to explore their best options (nearest option) to take a small cool break in Philadelphia.