Merge wasip2/wasip3 reading/writing#756
Merged
alexcrichton merged 2 commits intoWebAssembly:mainfrom Mar 3, 2026
Merged
Conversation
* Generalize the `wasip2_{read,write}_t` types to `wasi_{read,write}_t`
with conditional internals depending on the WASI version.
* Fix error handling for stdin to use stdin error codes instead of
filesystem error codes.
* Call `subtask.drop` for writes to acknowledge the subtask being done.
* When stdin is done, drop the future for the error after it's read to
ensure the future isn't read twice.
alexcrichton
force-pushed
the
merge-wasip2-wasip3-read-write
branch
from
c377a42 to
4f0cc5a
Compare
alexcrichton
force-pushed
the
merge-wasip2-wasip3-read-write
branch
from
7ce44ad to
f967edb
Compare
dicej
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasip2_{read,write}_ttypes towasi_{read,write}_twith conditional internals depending on the WASI version.subtask.dropfor writes to acknowledge the subtask being done.