[wasm-split] "Move" secondary functions #8244
Closed
+16
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moveSecondaryFunctions, despite the name, actually copies functions to secondary modules and removes them from the primary module. This prevents this overhead by actually moving the functions to secondary modules. This reduces the running time on acx_gallery (provided by @biggs0125) by 31%.Time: 16.4s
Task breakdown:
Time: 11.3s
Task breakdown:
We can see the time spent in
moveSecondaryFunctions, which used to take nearly half of the running time (after #8221), is now negligible.