Add initial script to generate relaxed atomics spec test #8220
+154
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
generate-spec-test
branch
from
2200bdf to
0c37e1b
Compare
stevenfontanella
changed the title
tlively
reviewed
Jan 20, 2026
rmahdav
reviewed
Jan 21, 2026
Member
Author
|
I had a mistake with the section's length calculation, which was only coincidentally correct when 2 instructions were being tested. I fixed it now and tested it locally with more ops. |
tlively
reviewed
Jan 21, 2026
stevenfontanella
added a commit
that referenced
this pull request
Jan 23, 2026
stevenfontanella
changed the title
Member
Author
|
I more or less started over and fixed the handling for i32 vs i64 (the earlier iteration wouldn't making the memory index match the memory that we're accessing e.g. (i64.const ...) when accessing the 64-bit memory). I'll add the text tests first and then do the binary tests in the next PR. In the meantime, I'll keep the existing relaxed-atomics.wast test. This script populates relaxed-atomics2.wast. |
tlively
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8165. test/spec/relaxed-atomics2.wast was generated by the script. Binary tests will be added in the next PR.
Will add missing instructions e.g. load8, i64 instructions, etc once the approach looks good.
The ruff warning for E741 probably isn't triggering anymore, but I chose to disable it because it disallows variables named
lbecause it could be confused withIwhich I think isn't relevant in text editors.