Conversation
This comment has been minimized.
This comment has been minimized.
…ctor and HeaderCountrySelector
…useAnimation hook
…Animation hook and CSS keyframes
… subheading, paragraph, quantity)
Sections now blur-in with fade-up on scroll using the shared IntersectionObserver. Link component gains ScrollReveal parity with Heading, Button, and Paragraph.
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)
The variant media grouping feature uses filename-based matching, not variant.image URLs, so this query field was dead weight.
Add variant-based media grouping for product pages
…itions using ScrollReveal component
… 5.0.11, weaverse/hydrogen 5.9.2, mini-oxygen 4.0.1
… nursery to style
Some pages (product, collection, all-products) should not have the
scroll-reveal entrance animation since their content is immediately
visible. This adds an `animate` prop (defaults to true) and passes
animate={false} on those pages.
Also fixes MutableRefObject → RefObject type usage and sorts imports.
…nk lines Also replaced non-null assertion with optional chaining on groupedMedia.get().
…terns Add startsWith checks for option values at the beginning of filenames (e.g., black_xxx.jpg). Convert string concatenation to template literals to satisfy Biome. Update spec to reflect the actual implementation.
Import sorting, line wrapping, remove unused useMemo import, i++ → i += 1, and minor formatting adjustments.
Refactor the monolithic product-media.tsx and media-zoom.tsx into a product-media/ directory with focused modules: index (orchestrator), media-grid, media-slider, media-item, media-zoom, and utils.
Split the flat main-product section into two Weaverse child components: - mp--media: wraps ProductMedia with all media settings, hosts badges as overlay - mp--info: sticky container for all product info children (breadcrumb, title, etc.) This moves badges onto the product media as an absolute-positioned overlay, eliminating layout shift when badges appear/disappear on variant change.
Move swiper state + variant sync into MediaSlider, expanded state + variant reset into MediaGrid. ProductMedia index becomes stateless.
Pass allMedia (ungrouped) to ZoomModal so visitors can browse all product images without closing the modal to switch variants.
Render all media items and use lg:hidden to hide overflow on desktop only. Show more/less buttons hidden on mobile via hidden lg:flex since mobile uses horizontal scroll where all items are accessible.
Prevents tall portrait images from exceeding viewport height on large monitors by splitting the slider into 2 visible slides.
Use onSlideChange + realIndex to reliably highlight only the active thumbnail, fixing double-highlight in 2-slide-per-view mode.
Expose --thumbs-width CSS variable on the media wrapper and use it to shift badges left position past the thumbnail sidebar.
…ation Replace selectedVariant-based slide sync with displayMedia-based reset to index 0. Add onClick to thumb slides using slideToLoop for reliable navigation with loop mode.
Add breakpointsBase='container' so slidesPerView adapts based on the media column width rather than viewport width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8.1.0 (WIP)
This is a work-in-progress PR for the next minor release. More updates will be added before merging.
Changes so far
.hydrogen/andguides/into.guides/hydrogen-upgrades/and.guides/cookbooks/useMemo/useCallbackusage (React 19 compiler handles memoization)cvaanimateprop to Section component to disable scroll-reveal on product/collection pagesCloses #340
Closes #321