Premium

[eeVoskos]

No description provided.

[eeVoskos]

@CodeRabbit review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt (1)

52-359: ⚠️ Potential issue | 🟡 Minor

Split PremiumPlanView into smaller composables to reduce cyclomatic complexity.

PremiumPlanView is at complexity 17 (threshold 15), so this currently fails Detekt. Extracting header, promo banners, pricing, and feature list into private composables should resolve this cleanly.

Refactor outline

 fun PremiumPlanView(...) {
-    // full UI with header + badges + promo + pricing + features + debug label
+    PremiumHeader(isCurrentPlan = isCurrentPlan, primaryColor = primaryColor)
+    PremiumPromoSection(sub = sub, hasFreeTrialAvailable = hasFreeTrialAvailable)
+    PremiumPricingSection(sub = sub)
+    PremiumDescriptionAndFeatures()
+    DebugOfferId(sub = sub)
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt`
around lines 52 - 359, PremiumPlanView exceeds Detekt's cyclomatic complexity
threshold (17 > 15); split it into smaller private composables to reduce
complexity: extract the header row (including LargeText and the current-plan /
best-accuracy badge) into a private HeaderComposable, extract the free-trial
token banner (logic using TAG_FREE_TRIAL, freeTrialPeriod) into FreeTrialBanner,
extract the launch offer title block (TAG_LAUNCH_OFFER) into LaunchOfferTitle,
extract the pricing section (uses sub.price, PLAN_MONTHLY/PLAN_YEARLY,
TAG_DISCOUNT, discountedCycles, basePrice) into PricingComposable, and extract
the features list (uses PremiumFeatureItem and annotated strings) into
FeaturesComposable; replace the corresponding inline blocks in PremiumPlanView
with calls to these new private composables and pass only the needed parameters
(sub, isCurrentPlan, hasFreeTrialAvailable, isSelected) to keep each function
focused and reduce overall cyclomatic complexity.

♻️ Duplicate comments (5)

app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt (2)

225-227: ⚠️ Potential issue | 🟡 Minor

Wrap toIntOrNull() to a new line in the nullable chain.

Line 226 still violates CascadingCallWrapping.

Proposed fix

                                 val freeTrialMonths = sub.freeTrialPeriod
-                                    ?.filter { it.isDigit() }?.toIntOrNull() ?: 2
+                                    ?.filter { it.isDigit() }
+                                    ?.toIntOrNull() ?: 2

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt`
around lines 225 - 227, The nullable chain assigning freeTrialMonths (variable
freeTrialMonths using sub.freeTrialPeriod) should place the ?.toIntOrNull() on
its own line to satisfy CascadingCallWrapping; refactor the expression so the
filter call stays on one line and the subsequent ?.toIntOrNull() is moved to a
new line before the elvis fallback (?: 2), e.g. keep sub.freeTrialPeriod?.filter
{ it.isDigit() } on one line and put ?.toIntOrNull() on the next line to
preserve nullable chaining and fix the lint violation.

---

298-303: ⚠️ Potential issue | 🟡 Minor

Break the long discount condition into a multiline boolean.

Line 298 still exceeds max line length and fails Detekt.

Proposed fix

-                    if (TAG_DISCOUNT in sub.tags && sub.discountedCycles != null && sub.basePrice != null) {
+                    val hasDiscount = TAG_DISCOUNT in sub.tags &&
+                        sub.discountedCycles != null &&
+                        sub.basePrice != null
+                    if (hasDiscount) {
                         val discountStringRes = if (TAG_FREE_TRIAL in sub.tags) {
                             R.string.offer_discount_after_trial
                         } else {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt`
around lines 298 - 303, The long boolean condition in PremiumPlanView.kt (the if
checking TAG_DISCOUNT in sub.tags && sub.discountedCycles != null &&
sub.basePrice != null) exceeds max line length; refactor it into a multiline
boolean by grouping each predicate on its own line (e.g., split "TAG_DISCOUNT in
sub.tags", "sub.discountedCycles != null", and "sub.basePrice != null" across
multiple lines with proper parentheses) and keep the nested TAG_FREE_TRIAL check
for discountStringRes unchanged so the logic remains identical.

app/src/test/java/com/weatherxm/ui/forecastdetails/ForecastDetailsViewModelTest.kt (1)

260-260: ⚠️ Potential issue | 🟡 Minor

Shorten or wrap the test description string to satisfy max line length.

Line 260 still exceeds the configured line length limit.

Proposed fix

-                    then("LiveData onDeviceDefaultForecast should post the error for the empty forecast") {
+                    then("LiveData onDeviceDefaultForecast should post error for empty forecast") {
                         viewModel.onDeviceDefaultForecast().isError(emptyForecastMsg)
                     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@app/src/test/java/com/weatherxm/ui/forecastdetails/ForecastDetailsViewModelTest.kt`
at line 260, The test description string in ForecastDetailsViewModelTest (the
then(...) call in ForecastDetailsViewModelTest.kt) is too long; shorten or wrap
it to satisfy line-length limits by replacing the current message ("LiveData
onDeviceDefaultForecast should post the error for the empty forecast") with a
shorter phrase (e.g., "LiveData onDeviceDefaultForecast posts error for empty
forecast") or split it across concatenated strings so the then("...") argument
no longer exceeds the max line length.

app/src/main/java/com/weatherxm/service/BillingService.kt (2)

237-239: ⚠️ Potential issue | 🟡 Minor

Wrap the Elvis return@forEach on a separate line in the call chain.

Line 239 still violates CascadingCallWrapping and is a current pipeline blocker.

Proposed fix

                 val displayPrice = (discountPhase ?: basePhase)
                     ?.formattedPrice
-                    ?.replaceLast(" ", "") ?: return@forEach
+                    ?.replaceLast(" ", "")
+                    ?: return@forEach

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/main/java/com/weatherxm/service/BillingService.kt` around lines 237 -
239, The Elvis operator's fallback "return@forEach" is currently on the same
line as the call chain, which violates CascadingCallWrapping; move the "?:
return@forEach" onto its own line after the chained calls so the chain ends on
its own line — locate the expression that builds displayPrice (using
discountPhase, basePhase, formattedPrice and the call to replaceLast) and place
the Elvis operator and return@forEach on a separate line to satisfy the wrapping
rule.

---

216-224: ⚠️ Potential issue | 🟡 Minor

Break the debug Timber logs into wrapped multiline strings.

Line 219 and Line 223 still exceed the max line length and are currently failing Detekt.

Proposed fix

         if (BuildConfig.DEBUG) {
             productDetails.also {
-                Timber.d("Product [id=${it?.productId}, name = ${it?.name}, description = ${it?.description}, title = ${it?.title}]]")
+                Timber.d(
+                    "Product [id=${it?.productId}, name=${it?.name}, " +
+                        "description=${it?.description}, title=${it?.title}]"
+                )
                 it?.subscriptionOfferDetails?.forEach { o ->
                     Timber.d("\tOffer [id=${o.offerId}, tags = ${o.offerTags}]")
                     o.pricingPhases.pricingPhaseList.forEach { p ->
-                        Timber.d("\t\tPhase [pricef = ${p.formattedPrice}, period = ${p.billingPeriod}, cycles = ${p.billingCycleCount}, recur = ${p.recurrenceMode}], price = ${p.priceAmountMicros}, curr = ${p.priceCurrencyCode}]")
+                        Timber.d(
+                            "\t\tPhase [pricef=${p.formattedPrice}, period=${p.billingPeriod}, " +
+                                "cycles=${p.billingCycleCount}, recur=${p.recurrenceMode}], " +
+                                "price=${p.priceAmountMicros}, curr=${p.priceCurrencyCode}]"
+                        )
                     }
                 }
             }
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/main/java/com/weatherxm/service/BillingService.kt` around lines 216 -
224, The Timber debug logs in the productDetails block (calls to Timber.d within
the if (BuildConfig.DEBUG) and the nested subscriptionOfferDetails/pricingPhases
loops) exceed max line length; refactor each Timber.d call to use wrapped
multiline/raw strings (e.g., Kotlin triple-quoted strings or build a small
StringBuilder/format block) and interpolate the same fields (productId, name,
description, title, o.offerId, o.offerTags, p.formattedPrice, p.billingPeriod,
p.billingCycleCount, p.recurrenceMode, p.priceAmountMicros, p.priceCurrencyCode)
across multiple shorter lines so no single line exceeds the limit while
preserving the exact logged values and structure.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt`:
- Around line 52-359: PremiumPlanView exceeds Detekt's cyclomatic complexity
threshold (17 > 15); split it into smaller private composables to reduce
complexity: extract the header row (including LargeText and the current-plan /
best-accuracy badge) into a private HeaderComposable, extract the free-trial
token banner (logic using TAG_FREE_TRIAL, freeTrialPeriod) into FreeTrialBanner,
extract the launch offer title block (TAG_LAUNCH_OFFER) into LaunchOfferTitle,
extract the pricing section (uses sub.price, PLAN_MONTHLY/PLAN_YEARLY,
TAG_DISCOUNT, discountedCycles, basePrice) into PricingComposable, and extract
the features list (uses PremiumFeatureItem and annotated strings) into
FeaturesComposable; replace the corresponding inline blocks in PremiumPlanView
with calls to these new private composables and pass only the needed parameters
(sub, isCurrentPlan, hasFreeTrialAvailable, isSelected) to keep each function
focused and reduce overall cyclomatic complexity.

---

Duplicate comments:
In `@app/src/main/java/com/weatherxm/service/BillingService.kt`:
- Around line 237-239: The Elvis operator's fallback "return@forEach" is
currently on the same line as the call chain, which violates
CascadingCallWrapping; move the "?: return@forEach" onto its own line after the
chained calls so the chain ends on its own line — locate the expression that
builds displayPrice (using discountPhase, basePhase, formattedPrice and the call
to replaceLast) and place the Elvis operator and return@forEach on a separate
line to satisfy the wrapping rule.
- Around line 216-224: The Timber debug logs in the productDetails block (calls
to Timber.d within the if (BuildConfig.DEBUG) and the nested
subscriptionOfferDetails/pricingPhases loops) exceed max line length; refactor
each Timber.d call to use wrapped multiline/raw strings (e.g., Kotlin
triple-quoted strings or build a small StringBuilder/format block) and
interpolate the same fields (productId, name, description, title, o.offerId,
o.offerTags, p.formattedPrice, p.billingPeriod, p.billingCycleCount,
p.recurrenceMode, p.priceAmountMicros, p.priceCurrencyCode) across multiple
shorter lines so no single line exceeds the limit while preserving the exact
logged values and structure.

In `@app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt`:
- Around line 225-227: The nullable chain assigning freeTrialMonths (variable
freeTrialMonths using sub.freeTrialPeriod) should place the ?.toIntOrNull() on
its own line to satisfy CascadingCallWrapping; refactor the expression so the
filter call stays on one line and the subsequent ?.toIntOrNull() is moved to a
new line before the elvis fallback (?: 2), e.g. keep sub.freeTrialPeriod?.filter
{ it.isDigit() } on one line and put ?.toIntOrNull() on the next line to
preserve nullable chaining and fix the lint violation.
- Around line 298-303: The long boolean condition in PremiumPlanView.kt (the if
checking TAG_DISCOUNT in sub.tags && sub.discountedCycles != null &&
sub.basePrice != null) exceeds max line length; refactor it into a multiline
boolean by grouping each predicate on its own line (e.g., split "TAG_DISCOUNT in
sub.tags", "sub.discountedCycles != null", and "sub.basePrice != null" across
multiple lines with proper parentheses) and keep the nested TAG_FREE_TRIAL check
for discountStringRes unchanged so the logic remains identical.

In
`@app/src/test/java/com/weatherxm/ui/forecastdetails/ForecastDetailsViewModelTest.kt`:
- Line 260: The test description string in ForecastDetailsViewModelTest (the
then(...) call in ForecastDetailsViewModelTest.kt) is too long; shorten or wrap
it to satisfy line-length limits by replacing the current message ("LiveData
onDeviceDefaultForecast should post the error for the empty forecast") with a
shorter phrase (e.g., "LiveData onDeviceDefaultForecast posts error for empty
forecast") or split it across concatenated strings so the then("...") argument
no longer exceeds the max line length.

---

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6761a74 and 3e0caea.

📒 Files selected for processing (4)

• app/src/main/java/com/weatherxm/service/BillingService.kt
• app/src/main/java/com/weatherxm/ui/common/UIModels.kt
• app/src/main/java/com/weatherxm/ui/managesubscription/PremiumPlanView.kt
• app/src/test/java/com/weatherxm/ui/forecastdetails/ForecastDetailsViewModelTest.kt

🚧 Files skipped from review as they are similar to previous changes (1)

• app/src/main/java/com/weatherxm/ui/common/UIModels.kt

[github-actions]

Coverage Report (Type: Instructions)

Overall Project	80.81% -6.06%	✅
Files changed	20.97%	✅

File	Coverage
RemoteBannersDataSource.kt	100%	✅
NetworkWeatherForecastDataSource.kt	100%	✅
CacheWeatherForecastDataSource.kt	100%	✅
ManageSubscriptionViewModel.kt	100%	✅
HomeViewModel.kt	97.42% -0.43%	✅
AnalyticsService.kt	97.28%	✅
WeatherForecastRepository.kt	96.78% -3.22%	✅
ForecastDetailsViewModel.kt	93.54% -6.46%	✅
DeviceDetailsViewModel.kt	88.67% -0.27%	✅
ChartsUseCaseImpl.kt	86.18%	✅
ForecastViewModel.kt	81.44% -11%	✅
Extensions.kt	80.43% -4.99%	✅
ForecastUseCaseImpl.kt	78.48% -15.49%	✅
ChartsUseCase.kt	65.22%	✅
WeatherForecastDataSource.kt	60% -38.18%	✅
ForecastUseCase.kt	57.89% -36.84%	✅
AndroidBuildInfo.kt	56.52% -8.7%	✅
UIModels.kt	52.65% -1.16%	✅
FreePlanView.kt	0% -96.48%	✅
PremiumPlanView.kt	0% -98.7%	✅