[fix][CGS][engineconn] fix sr task retry causing init_sql loading exception#964
Merged
casionone merged 4 commits intodev-1.18.0-webankfrom Mar 31, 2026
Merged
[fix][CGS][engineconn] fix sr task retry causing init_sql loading exception#964casionone merged 4 commits intodev-1.18.0-webankfrom
casionone merged 4 commits intodev-1.18.0-webankfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Background/Problem:
When SR (Script) tasks are retried, the init_sql loading process causes an exception due to null pointer exception when accessing the EngineTypeLabel. The method
adjustErrorIndexForSetScenariosusesfind().getwhich throws NoSuchElementException when the label is not present in the task labels.Purpose of Change:
To address this problem, this PR replaces the unsafe
find().getpattern withcollectFirstwhich safely handles the case when EngineTypeLabel is not present, and adds null check for executionCode to prevent null pointer exceptions.Value/Impact:
After the change, the system handles task retry scenarios gracefully without throwing exceptions, improving system stability and reliability.
Related issues/PRs
Related issues: close apache#5392
Related pr:none
Brief change log
find().getwithcollectFirstto safely access EngineTypeLabelChecklist