Skip to content

DRAFT scale: include all views visible on workspace#1775

Open
mntmn wants to merge 1 commit into
WayfireWM:masterfrom
mntmn:fix-scale
Open

DRAFT scale: include all views visible on workspace#1775
mntmn wants to merge 1 commit into
WayfireWM:masterfrom
mntmn:fix-scale

Conversation

@mntmn

@mntmn mntmn commented Apr 14, 2023

Copy link
Copy Markdown

Intuitively, "scale" should include all views that are visible in (overlap with) the current workspace, not only those that are mostly inside of it.

@ammen99

ammen99 commented Jun 9, 2023

Copy link
Copy Markdown
Member

@soreau Thoughts?

By the way, if we change the behavior as you propose, the whole function can be replaced with a single call:

output->wset()->get_views(wf::WSET_EXCLUDE_MINIMIZED | wf::WSET_MAPPED_ONLY | wf::WSET_CURRENT_WORKSPACE);

EDIT: this is with some changes which recently landed, this syntax wasn't available when you made the PR.

@ammen99 ammen99 requested a review from soreau June 9, 2023 11:50
@NamorNiradnug

NamorNiradnug commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

I think the behavior should be configurable to allow users to choose between old and new behavior.

Probably it should hide away views which region overlaps only a little with the region of the current workspace.

@ammen99 ammen99 added the stale label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants