Open
Conversation
Contributor
|
This seems sophisticated and really well written! The code is clean with good separation of concerns, and the test coverage is solid for the core functionality and the documentation provides good examples. A few small suggestions for potential improvements:
I think the current implementation is ready to use as is, but I would be happy to contribute/make any of these improvements if you all think they would be additive. |
5 tasks
* region set to CAISO_NORTH, remove assertion error * tested TestRecalculatingOptimizer * added parameter to limit print statements * started requery refactor * requery and simulator class * event loop example * requery functions in a testable state * example type hints * requery loop set up for review * moved recalculator tests and updated readme * adding recalculator tests - 2nd test fails * basic recalculator tests running * evalation classes * evaluation, session generation scripts ready for review * api, evaluator, utils updates * optimizer subpackage * synthetic notebook error corrected, other minor fixes * interval to segment * fit selection error fixed * notebook and battery class updates * Update Optimizer README.md * graphs * visuals cleanup * example notebooks * Update Optimizer README.md * Rename datacenter_workload_1.ipynb to datacenter_workloads.ipynb * requery bug fixed * contigous analysis loop working with conversion to int * all loops in working order * Update Optimizer README.md * Add files via upload * Update Optimizer README.md * Add files via upload * Update Optimizer README.md * Camille suggestions * Main readme updates - explanation + permalink * more permalinks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers from Two Sigma built out a forecast scheduler / optimizer. The workstream is complete and now needs additional integration testing before releasing to users.
More details forthcoming...