Open
Conversation
sam-watttime
commented
Dec 16, 2024
| self.assertIsInstance(jsons[0], dict) | ||
|
|
||
| def test_get_historical_jsons_1_week(self): | ||
| start = "2022-01-01 00:00Z" |
Contributor
Author
There was a problem hiding this comment.
a few local changes I included to update the data range of the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces shapely as a requirement, which is not ideal, although it isn't difficult to install typically. Alternatively, we could add it as an optional dependency (e.g.
pip install watttime[testing]).The cause of a failure for this test would most likely be in our data generation (e.g. uploading maps). A test was added inline in
export_all_cache.py, however this test is also a nice peace of mind to ensure that our users are actually getting valid geojson.