Open
Conversation
Create global/templates/NHP_NNP/ directory to hold NHP-specific template files required by FreeSurfer and fMRI pipelines. Template files will be added in subsequent commits. Related to PR Washington-University#364 review feedback.
Contributor
|
There seem like a lot of extraneous files in here. |
coalsont
reviewed
Mar 23, 2026
| @@ -0,0 +1 @@ | |||
| *.gca filter=lfs diff=lfs merge=lfs -text | |||
Member
There was a problem hiding this comment.
Note, we haven't used git-lfs so far.
coalsont
reviewed
Mar 23, 2026
Comment on lines
+17
to
+20
| *.gca | ||
| *0.25mm*.nii.gz | ||
| *0.15mm*.nii.gz | ||
| *0.1mm*.nii.gz |
Member
There was a problem hiding this comment.
It seems wrong to .gitignore file patterns like this. Even with git-lfs handling .gca files, is it really necessary to also .gitignore them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NHP template files and adjust parameters in some scripts.
Related to PR #364 review feedback.