all agents in orchestral flow publishes to queue #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViaSocket-Git
changed the title
Collaborator
Author
|
/windsurf-review |
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Comment on lines
+224
to
+227
| # Prepare queue data for this intermediate agent | ||
| queue_data = await make_request_data_and_publish_sub_queue(parsed_data, result, params, thread_info) | ||
| queue_data = make_json_serializable(queue_data) | ||
| current_history_data['queue_data'] = queue_data |
There was a problem hiding this comment.
Consider adding error handling around the queue data serialization to prevent potential runtime errors if the data contains non-serializable objects:
Suggested change
| # Prepare queue data for this intermediate agent | |
| queue_data = await make_request_data_and_publish_sub_queue(parsed_data, result, params, thread_info) | |
| queue_data = make_json_serializable(queue_data) | |
| current_history_data['queue_data'] = queue_data | |
| # Prepare queue data for this intermediate agent | |
| try: | |
| queue_data = await make_request_data_and_publish_sub_queue(parsed_data, result, params, thread_info) | |
| queue_data = make_json_serializable(queue_data) | |
| current_history_data['queue_data'] = queue_data | |
| except Exception as e: | |
| logger.error(f"Error serializing queue data: {str(e)}") | |
| # Still continue with the flow even if queue data couldn't be serialized |
Comment on lines
+513
to
+517
| # Publish all agents to queue | ||
| for history_entry in transfer_chain: | ||
| if 'queue_data' in history_entry: | ||
| await sub_queue_obj.publish_message(history_entry['queue_data']) | ||
|
|
There was a problem hiding this comment.
Missing error handling for queue publishing operations. If publishing fails for one agent, it could affect the entire chain. Consider adding try/except blocks around the publish operations to ensure the process continues even if one publish fails:
Suggested change
| # Publish all agents to queue | |
| for history_entry in transfer_chain: | |
| if 'queue_data' in history_entry: | |
| await sub_queue_obj.publish_message(history_entry['queue_data']) | |
| # Publish all agents to queue | |
| for history_entry in transfer_chain: | |
| if 'queue_data' in history_entry: | |
| try: | |
| await sub_queue_obj.publish_message(history_entry['queue_data']) | |
| except Exception as e: | |
| logger.error(f"Failed to publish queue message for agent {history_entry['bridge_id']}: {str(e)}") | |
Comment on lines
+464
to
+466
| queue_data = await make_request_data_and_publish_sub_queue(parsed_data, result, params, thread_info) | ||
| queue_data = make_json_serializable(queue_data) | ||
| current_history_data['queue_data'] = queue_data |
There was a problem hiding this comment.
Storing all queue_data in memory before publishing could lead to memory issues with large payloads or many agents in a complex flow. Consider publishing each agent's data immediately after preparing it rather than storing all data and publishing at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all intermediate agents in flow publishes to queue