Add CONFIG.md documenting all config.sh parameters and link from README.md#45
Conversation
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
|
@copilot please remove the example section from each parameter sub-section. |
|
@copilot please add (bullet point list) of all configurable parameters to the first section. |
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done — example sections removed from all 12 parameter subsections in commit |
Remove, the file will not be committed by a user ...
Remove
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done — a linked bullet-point list of all 12 parameters has been added to the intro section in commit |
Remove, this is not a developer documentation.
|
@copilot please add an example of how to set a config parameter for each config parameter subsection (the example should contain clear values what can be uses,not how to |
|
@copilot please add a reference to |
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done — each of the 12 parameter subsections now has an Example: |
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done — a reference to |
|
@copilot please add a remark to |
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done — a |
Add remark to change on installation media
|
@copilot add the following remarks to |
…and GRUB_KERNEL_CMDLINE in CONFIG.md Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done (commit
|
clauspruefer
left a comment
There was a problem hiding this comment.
@copilot 1. Change NEXTDNS_ID: add remark that config parameter must only be non-prefixed ("NextDNS-" ommited). 2. Change NEXTDNS_STAMP, also here the prefix "sdns://" must be ommited, also correct this in given example parameter value 3. In USER_IDS change "A space-separated list of local user account names that exist on the system." to "A space-separated list of users ... the installer will process hardening per user ... also must be defined in autoinstall.yaml else the installation is not 100%".
Co-authored-by: clauspruefer <17313789+clauspruefer@users.noreply.github.com>
Done (commit
|
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive configuration documentation by creating CONFIG.md with detailed descriptions of all 12 parameters in config.sh, and updates README.md to reference this new documentation. The changes improve the user experience by providing clear guidance on all configurable parameters, including their purpose, usage, requirements, and examples.
Changes:
- Created CONFIG.md documenting all configuration parameters with detailed descriptions, usage notes, and examples
- Added reference to CONFIG.md in README.md section 4.2 for configuration guidance
- Added clarifying note in README.md section 5.1.1 explaining that the YAML excerpt is simplified with links to full documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CONFIG.md | New comprehensive documentation covering all 12 config.sh parameters with descriptions, usage context, mandatory/optional status, technical notes, and examples |
| README.md | Updated configuration section to reference CONFIG.md and added clarifying note about simplified YAML example with links to full documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| The domain name assigned to the kernel via the `kernel.domainname` sysctl parameter. | ||
|
|
||
| Used by `set-sysctl.sh` when deploying `sysctl-10-domainname.conf`, replacing the `[KERNEL_DOMAIN_NAME]` placeholder. Set this to the DNS domain of the local network or organisation. |
There was a problem hiding this comment.
Spelling inconsistency: "organisation" should be "organization" to match the American English spelling used elsewhere in the codebase (e.g., "organizational" in CHANGELOG.md:114, "optimized" in CONFIG.md:144).
| Used by `set-sysctl.sh` when deploying `sysctl-10-domainname.conf`, replacing the `[KERNEL_DOMAIN_NAME]` placeholder. Set this to the DNS domain of the local network or organisation. | |
| Used by `set-sysctl.sh` when deploying `sysctl-10-domainname.conf`, replacing the `[KERNEL_DOMAIN_NAME]` placeholder. Set this to the DNS domain of the local network or organization. |
CONFIG.mdwith a subsection for each parameter inconfig.shCONFIG.mdinREADME.mdsection 4.2README.mdsection 5.1.1 that the YAML excerpt is simplified, with links to the full/autoinstall/autoinstall.yamland/autoinstall/README.mdNET_IF_NAME: managed bynetworkd,NET_IF_MACADDRESSandNET_IF_MTUare mandatory,installer-step1must run without network connectivity, ethernet-only installationNET_WIFI_IF_NAME: optional parameter, WiFi managed by NetworkManager notnetworkdNET_NTP_STATIC_SERVER: optional parameter, adjustedchronyconfig can be used if omittedGRUB_KERNEL_CMDLINE: must be set with system-specific values, default optimized for Intel Gen 9 CPU with i915 GPU (disables DMAR, limits C-state for performance)NEXTDNS_IDthat the value must omit theNextDNS-prefixNEXTDNS_STAMPthat the value must omit thesdns://prefix; fix example value to exclude the prefixUSER_IDSdescription to clarify the installer processes hardening per user, and that all listed users must also be defined inautoinstall.yamlfor a complete installation💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.