Backport #9399#17
Conversation
|
Since this is less of a shoe-in (as in: can clearly see this exactly fixes the issue and breaks nothing else) fix than the rabbit hats imo (though that could just be my unfamiliarity with the assembly process; is there some kind of tree or graph search involved that keeps adding towards the outer blocks?), I would be inclined to hold off on this backport until the original is merged or I've really tested this extensively, but I do appreciate you making the PR already (: Some quick nits, please make the mixin abstract, and you can also add an unticked check box with the original PR linked, to REPAIRED.md in the appropriate category |
|
Done, as i understand it, each time a block is added its neighbours are checked to see if they are attached (second half of doors, redstone stuff, torches, etc) and those are added too, so its kind of a tree of dependencies for that part of the blocks stored (since areas with glue will not have this dependencies). That's why at least those need to be removed in the reverse order they where added, if one of the base block gets removed first, all dependants pop. The original structure is a map, so iteration order is not guarantied, maybe that's why it changed from 1.18.2 to 1.20.1 (not sure), and the change does not alters the signatures, if they wanted a map, they are getting a map, the only place where the order mattered was for the removing of the blocks, because on the placing of blocks the updates are suppressed by the brittle tag. My ideal would be not to touch the actual order like in the 1.21.1 fix, but it should not affect in 1.20.1 since no one depends on it (except us) |
Backport of Creators-of-Create/Create#9399 fixes #16