Conversation
dosumis
commented
Jul 26, 2021
dosumis
left a comment
dosumis
left a comment
Member
Author
There was a problem hiding this comment.
Changes requested - see comments.
| self.ew.commit() | ||
| return out | ||
|
|
||
| def add_genotype(self, genotype, add_feats=True, add_feature_details=False, commit=False): |
Member
Author
There was a problem hiding this comment.
rename arg to genotype_components
|
|
||
| if commit: | ||
| self.ni.commit() | ||
| self.ew.commit() |
Member
Author
There was a problem hiding this comment.
If either commit returns false, function returns false. Else return new ID.
dosumis
commented
Jul 26, 2021
dosumis
left a comment
dosumis
left a comment
Member
Author
There was a problem hiding this comment.
Consider adding test to see if this already exists.
| genotype_name = ', '.join(feat_names) | ||
|
|
||
| # synonym (FlyBase IDs) | ||
| feat_IDs = [n.short_form for n in feats.values()] # list of FB IDs of features in genotype |
| # iri['iri'] is long form, iri['short_form'] is short form | ||
|
|
||
| # label | ||
| feat_names = [n.label for n in feats.values()] # list of labels of features in genotype |
Member
Author
There was a problem hiding this comment.
Please sort alphanumerically
…abel of the desired genotype
Contributor
|
related to #239 |
Contributor
|
Genotype addition/editing is working with features already in the kb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.