Skip to content

Conversation

@koo-virtuals
Copy link
Contributor

@koo-virtuals koo-virtuals commented Feb 10, 2026

Note

Medium Risk
Changes a core launch entrypoint (BondingV4.preLaunch) and adds new launch-mode state/fees that affect who can update tax recipients and what fees are charged. Requires careful review of backward compatibility and on-chain upgrade/storage layout implications.

Overview
Adds an ACP_SKILL launch mode to BondingV4, including new isAcpSkillLaunch tracking, a configurable acpSkillLaunchFee, and a unified preLaunch(..., launchMode_) API that selects fees/flags based on launch mode.

Updates AgentTax.updateCreatorForProjectXLaunchAgents to also allow ACP_SKILL tokens (and swaps to minimal BondingV2/BondingV4 interfaces), adjusts Hardhat compiler overrides for BondingV4, and expands/updates the projectXLaunch test suite to use the new launchMode_ parameter and cover ACP_SKILL scenarios. Also refreshes .openzeppelin/base-sepolia.json to include the new BondingV4 storage layout/implementation metadata.

Written by Cursor Bugbot for commit bde44bd. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

},
viaIR: false,
},
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler override targets non-existent file path

Medium Severity

The new compiler override targets contracts/newLaunchpad/BondingV4.sol, but this file does not exist. The actual contract modified in this PR is at contracts/launchpadv2/BondingV4.sol. This means the intended viaIR: false setting won't apply to the real BondingV4 contract, which will instead compile with the default viaIR: true. This could produce different bytecode or cause compilation issues (e.g., "stack too deep") for the actual contract. The PR reviewer's comment "Can we remove this from config" likely refers to this same concern.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants