ES5 Support#8
Open
alan2207 wants to merge 2 commits into
Open
Conversation
|
Our project needs this. We get this error with create-react-app build: |
|
Can we merge this soon? Our project needs it as well |
Author
|
@lantelyes if you can migrate to using CRA v2 there is no need for transpiling to ES5 and this issue will not happen. https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify |
|
Any chance for merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added .babelrc file to define babel-preset-es2015 in presets.
Transpiled the lib folder to ES5 so that it is supported by all browsers.
The reason behind this pull request was this error caused by non-transpiled ES6 code in the current lib folder.