Option for default horizontal position!#6
Open
fuyangli wants to merge 3 commits intoVicta:masterfrom
fuyangli:master
Open
Option for default horizontal position!#6fuyangli wants to merge 3 commits intoVicta:masterfrom fuyangli:master
fuyangli wants to merge 3 commits intoVicta:masterfrom
fuyangli:master
Conversation
$('.parallax').scrolly({bgParallax: true, horizontalPos: '100%'});
Using jquery scroll event (so it starts only when it really scrolled) and adjusting image on page refresh (before, we need to scroll something to adjust the initial position of the image)
jquery.scrolly.js
Outdated
Owner
There was a problem hiding this comment.
I think bind is deprecated, no? Maybe I'm wrong, but we should try to use on instead.
Author
There was a problem hiding this comment.
I guess you're right!
As seen in http://stackoverflow.com/questions/11847021/jquery-bind-vs-on, bind maps to on, but will be deprecated!
Bind will be deprecated, so use on instead.
Owner
There was a problem hiding this comment.
I did that on purpose. See http://joshbroton.com/hooking-up-to-the-window-onscroll-event-without-killing-your-performance/
The performance are still bad. If I want to re-write this plugin I'll use requestAnimationFrame which is way better https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$('.parallax').scrolly({bgParallax: true, horizontalPos: '100%'});