Allowing different paths for different video files#11
Open
mattlima wants to merge 3 commits intoVicta:masterfrom
mattlima:master
Open
Allowing different paths for different video files#11mattlima wants to merge 3 commits intoVicta:masterfrom mattlima:master
mattlima wants to merge 3 commits intoVicta:masterfrom
mattlima:master
Conversation
Modified to optionally accept an object as the path argument instead of a string. If you have to reference video files in different locations (for example on a Wordpress site where they were not uploaded at the same time and are in different subdirectories of wp-content/uploads) this can be useful. Object properties should be strings corresponding to the members of the types array.
Added a note about the change to the path argument.
updated via http://jscompress.com/ to match jquery.backgroundvideo.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a wordpress custom CMS that controls a page using the plugin to supply the background video. Because wordpress segregates uploaded files into directories by date of upload, it's not safe to assume all the videos reside at the same path. As a failsafe, I modified the plugin to optionally accept an Object for the
pathargument in which case it pulls path information based on thetypesargument array members. Perhaps this will be useful for someone else.