Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 8c15f62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
therealemjy
force-pushed
the
feat/v4-phase-3
branch
from
66041dd to
379df57
Compare
therealemjy
force-pushed
the
feat/v4-phase-3
branch
from
379df57 to
e9da8f6
Compare
therealemjy
force-pushed
the
feat/v4-phase-3
branch
from
e9da8f6 to
91ac46d
Compare
Member
Author
|
@greptile |
Greptile SummaryThis PR implements v4 phase 3 updates to the Markets and Market pages. The changes include a major refactoring of the page structure with improved component organization and new features. Key Changes:
The refactoring follows good practices with proper separation of concerns, comprehensive test coverage, and consistent TypeScript typing throughout. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 91ac46d |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "supplyButton": { | ||
| "label": "存款" | ||
| }, | ||
| "textTitle": "焦点" |
Contributor
There was a problem hiding this comment.
I would recommend "聚焦". What do you think? @zed-venus
There was a problem hiding this comment.
I think we can translate this from meaning perspective, "精选市场“ or “精选”
Contributor
There was a problem hiding this comment.
After discussion with @zed-venus , will settle it to "精选"，and for zh-Hant, it is "精選"。
david-sun-venus
force-pushed
the
feat/v4-phase-3
branch
from
b1afab6 to
42983fb
Compare
therealemjy
force-pushed
the
feat/v4-phase-3
branch
from
895043d to
4e6c79e
Compare
therealemjy
force-pushed
the
feat/v4-phase-3
branch
from
4e6c79e to
8c15f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket(s)
VPD-464
VPD-577
VPD-576
VPD-465
Changes