Feat/drop legacy LOrders

CLAUDE.md

@@ -47,7 +47,7 @@ Each file exports `constructContractCaller(provider, account)` → `ContractCall
 
 - `delta/` — Core feature: Delta auction orders (server-side order building, route-based pricing, paginated orders; see detail below)
 - `swap/` — Token swap: rates, transaction building, approvals, balances
-- `limitOrders/` — **Deprecated.** EIP-712 signed limit orders
+- `otcOrders/` — EIP-712 signed OTC orders
 - `nftOrders/` — **Deprecated.** EIP-712 signed NFT orders
 - `quote/` — Unified `/v2/quote` endpoint (mode-selectable Delta v2 price / market / fallback)
 
@@ -58,7 +58,7 @@ Every feature module exports a `constructXxx(options) => XxxFunctions` factory:
 - `D` selects required caller methods: `'transactCall'` | `'signTypedDataCall'` | both
 - Generic `<T>` = transaction response type (e.g., `TxHash`, `ethers.ContractTransaction`)
 - Non-generic constructors use `any` (for API-only flows that don't return tx responses)
-- All Delta constructors are combined in `constructAllDeltaOrdersHandlers` in `src/methods/delta/index.ts`. **Convention:** bind each `constructXxx(options)` call to a named local (`const deltaPrice = constructGetDeltaPrice(options)`), then spread those locals into the returned object — don't spread the constructor calls inline. (Matches `constructAllLimitOrdersHandlers`.)
+- All Delta constructors are combined in `constructAllDeltaOrdersHandlers` in `src/methods/delta/index.ts`. **Convention:** bind each `constructXxx(options)` call to a named local (`const deltaPrice = constructGetDeltaPrice(options)`), then spread those locals into the returned object — don't spread the constructor calls inline.
 
 ## Key Patterns
 

package.json

@@ -56,6 +56,7 @@
     "@size-limit/preset-small-lib": "^12.1.0",
     "@tsconfig/recommended": "^1.0.8",
     "@types/jest": "^30.0.0",
+    "@types/node": "^22.8.5",
     "@wagmi/connectors": "^8.0.13",
     "@wagmi/core": "^3.4.11",
     "axios": "^1.13.2",
@@ -131,4 +132,4 @@
   },
   "bugs": "https://github.com/VeloraDEX/paraswap-sdk/issues",
   "packageManager": "pnpm@11.1.2"
-}
+}

src/examples/limitOrders_all.ts → src/examples/otcOrders_all.ts

@@ -8,14 +8,15 @@ import {
   constructPartialSDK,
   constructEthersContractCaller,
   constructAxiosFetcher,
-  // limitOrders methods
-  constructAllLimitOrdersHandlers,
+  // OTCOrders methods
+  constructAllOTCOrdersHandlers,
   // extra types
-  LimitOrderFromApi,
+  OTCOrder,
   SwappableOrder,
 } from '..';
 
 const account = '0x1234...';
+const takerAccount = '0x5678...';
 
 const fetcher = constructAxiosFetcher(axios);
 
@@ -30,17 +31,17 @@ const contractCaller = constructEthersContractCaller(
   account
 );
 
-// type BuildLimitOrderFunctions
-// & SignLimitOrderFunctions
-// & CancelLimitOrderFunctions<ethers.ContractTransaction>
+// type BuildOTCOrderFunctions
+// & SignOTCOrderFunctions
+// & CancelOTCOrderFunctions<ethers.ContractTransaction>
 // & ApproveTokenFunctions<ethers.ContractTransaction>
-const limitOrderSDK = constructPartialSDK(
+const OTCOrderSDK = constructPartialSDK(
   {
     chainId: 1,
     fetcher,
     contractCaller,
   },
-  constructAllLimitOrdersHandlers
+  constructAllOTCOrdersHandlers
 );
 
 const DAI = '0x6B175474E89094C44Da98b954EedeAC495271d0F';
@@ -54,26 +55,25 @@ const orderInput = {
   makerAmount: (1e18).toString(10),
   takerAmount: (8e18).toString(10),
   maker: account,
+  taker: takerAccount,
 };
 
 async function run() {
-  // approve token for the limit order
+  // approve token for the OTC order
   const tx1: ethers.ContractTransaction =
-    await limitOrderSDK.approveMakerTokenForLimitOrder(
+    await OTCOrderSDK.approveMakerTokenForOTCOrder(
       orderInput.makerAmount,
       orderInput.makerAsset
     );
 
   // builds + signs + posts order to API
-  // new limit order returned from API
-  const newLimitOrder: LimitOrderFromApi = await limitOrderSDK.submitLimitOrder(
-    orderInput
-  );
+  // new OTC order returned from API
+  const newOTCOrder: OTCOrder = await OTCOrderSDK.submitOTCOrder(orderInput);
 
   // to act as order taker
   const anotherAccount = '0x5678...';
 
-  const limitOrdersSDKForTaker = constructPartialSDK(
+  const OTCOrdersSDKForTaker = constructPartialSDK(
     {
       chainId: 1,
       fetcher,
@@ -85,22 +85,22 @@ async function run() {
         anotherAccount
       ),
     },
-    constructAllLimitOrdersHandlers
+    constructAllOTCOrdersHandlers
   );
 
   const tx2: ethers.ContractTransaction =
-    await limitOrdersSDKForTaker.approveTakerTokenForLimitOrder(
+    await OTCOrdersSDKForTaker.approveTakerTokenForOTCOrder(
       orderInput.takerAmount,
       orderInput.takerAsset
     );
 
   const executingOrder: SwappableOrder = {
-    ...newLimitOrder,
-    permitMakerAsset: newLimitOrder.permitMakerAsset || undefined,
+    ...newOTCOrder,
+    permitMakerAsset: newOTCOrder.permitMakerAsset || undefined,
   };
 
   const { gas: payloadGas, ...LOPayloadTxParams } =
-    await limitOrdersSDKForTaker.buildLimitOrderTx({
+    await OTCOrdersSDKForTaker.buildOTCOrderTx({
       srcDecimals: 18,
       destDecimals: 18,
       userAddress: anotherAccount, // taker

src/examples/limitOrders_partial.ts → src/examples/otcOrders_partial.ts

@@ -8,20 +8,21 @@ import {
   constructPartialSDK,
   constructEthersContractCaller,
   constructAxiosFetcher,
-  // limitOrders methods
-  constructBuildLimitOrder,
-  constructCancelLimitOrder,
-  constructSignLimitOrder,
-  constructGetLimitOrders,
-  constructPostLimitOrder,
-  constructApproveTokenForLimitOrder,
+  // OTCOrders methods
+  constructBuildOTCOrder,
+  constructCancelOTCOrder,
+  constructSignOTCOrder,
+  constructGetOTCOrders,
+  constructPostOTCOrder,
+  constructApproveTokenForOTCOrder,
   // extra types
   SignableOrderData,
-  LimitOrderToSend,
-  constructBuildLimitOrderTx,
+  OTCOrderToPost,
+  constructBuildOTCOrderTx,
 } from '..';
 
 const account = '0x1234...';
+const takerAccount = '0x5678...';
 
 const fetcher = constructAxiosFetcher(axios);
 
@@ -36,22 +37,22 @@ const contractCaller = constructEthersContractCaller(
   account
 );
 
-// type BuildLimitOrderFunctions
-// & SignLimitOrderFunctions
-// & CancelLimitOrderFunctions<ethers.ContractTransaction>
+// type BuildOTCOrderFunctions
+// & SignOTCOrderFunctions
+// & CancelOTCOrderFunctions<ethers.ContractTransaction>
 // & ApproveTokenFunctions<ethers.ContractTransaction>
-const limitOrderSDK = constructPartialSDK(
+const OTCOrderSDK = constructPartialSDK(
   {
     chainId: 1,
     fetcher,
     contractCaller,
   },
-  constructBuildLimitOrder,
-  constructCancelLimitOrder,
-  constructSignLimitOrder,
-  constructPostLimitOrder,
-  constructGetLimitOrders,
-  constructApproveTokenForLimitOrder
+  constructBuildOTCOrder,
+  constructCancelOTCOrder,
+  constructSignOTCOrder,
+  constructPostOTCOrder,
+  constructGetOTCOrders,
+  constructApproveTokenForOTCOrder
 );
 
 const DAI = '0x6B175474E89094C44Da98b954EedeAC495271d0F';
@@ -65,55 +66,56 @@ const orderInput = {
   makerAmount: (1e18).toString(10),
   takerAmount: (8e18).toString(10),
   maker: account,
+  taker: takerAccount,
 };
 
 async function run() {
   /// cancelling current orders
-  const { orders: currentOrders } = await limitOrderSDK.getLimitOrders({
+  const { orders: currentOrders } = await OTCOrderSDK.getOTCOrders({
     maker: account,
-    type: 'LIMIT',
   });
 
   if (currentOrders[0]?.orderHash) {
-    const tx1: ethers.ContractTransaction =
-      await limitOrderSDK.cancelLimitOrder(currentOrders[0].orderHash);
+    const tx1: ethers.ContractTransaction = await OTCOrderSDK.cancelOTCOrder(
+      currentOrders[0].orderHash
+    );
   }
 
   const moreOrderHashes = currentOrders
     .slice(1, 2)
     .map((order) => order.orderHash);
 
-  const tx2: ethers.ContractTransaction =
-    await limitOrderSDK.cancelLimitOrderBulk(moreOrderHashes);
+  const tx2: ethers.ContractTransaction = await OTCOrderSDK.cancelOTCOrdersBulk(
+    moreOrderHashes
+  );
 
   /// creating a new order
 
   const tx3: ethers.ContractTransaction =
-    await limitOrderSDK.approveMakerTokenForLimitOrder(
+    await OTCOrderSDK.approveMakerTokenForOTCOrder(
       orderInput.makerAmount,
       orderInput.makerAsset
     );
 
-  const signableOrderData: SignableOrderData =
-    await limitOrderSDK.buildLimitOrder(orderInput);
-
-  const signature: string = await limitOrderSDK.signLimitOrder(
-    signableOrderData
+  const signableOrderData: SignableOrderData = await OTCOrderSDK.buildOTCOrder(
+    orderInput
   );
 
-  const orderToPostToApi: LimitOrderToSend = {
+  const signature: string = await OTCOrderSDK.signOTCOrder(signableOrderData);
+
+  const orderToPostToApi: OTCOrderToPost = {
     ...signableOrderData.data,
     signature,
   };
 
-  const newOrder = await limitOrderSDK.postLimitOrder(orderToPostToApi);
+  const newOrder = await OTCOrderSDK.postOTCOrder(orderToPostToApi);
 
   /// filling an order
 
   // to act as order taker
   const anotherAccount = '0x5678...';
 
-  const limitOrderSDKForTaker = constructPartialSDK(
+  const OTCOrderSDKForTaker = constructPartialSDK(
     {
       chainId: 1,
       fetcher,
@@ -125,18 +127,18 @@ async function run() {
         anotherAccount
       ),
     },
-    constructBuildLimitOrderTx,
-    constructApproveTokenForLimitOrder
+    constructBuildOTCOrderTx,
+    constructApproveTokenForOTCOrder
   );
 
   const tx4: ethers.ContractTransaction =
-    await limitOrderSDKForTaker.approveTakerTokenForLimitOrder(
+    await OTCOrderSDKForTaker.approveTakerTokenForOTCOrder(
       orderInput.takerAmount,
       orderInput.takerAsset
     );
 
   const { gas: payloadGas, ...LOPayloadTxParams } =
-    await limitOrderSDKForTaker.buildLimitOrderTx({
+    await OTCOrderSDKForTaker.buildOTCOrderTx({
       srcDecimals: 18,
       destDecimals: 18,
       userAddress: anotherAccount, // taker

src/examples/limitOrders_postOrder.ts → src/examples/otcOrders_postOrder.ts

@@ -7,16 +7,17 @@ import {
   constructPartialSDK,
   constructEthersContractCaller,
   constructAxiosFetcher,
-  // limitOrders methods
-  constructBuildLimitOrder,
-  constructSignLimitOrder,
-  constructPostLimitOrder,
+  // OTCOrders methods
+  constructBuildOTCOrder,
+  constructSignOTCOrder,
+  constructPostOTCOrder,
   // extra types
   SignableOrderData,
-  LimitOrderToSend,
+  OTCOrderToPost,
 } from '..';
 
 const wallet = ethers.Wallet.createRandom();
+const takerAccount = '0x5678...';
 
 const fetcher = constructAxiosFetcher(axios);
 
@@ -29,19 +30,19 @@ const contractCaller = constructEthersContractCaller(
   wallet.address
 );
 
-// type BuildLimitOrderFunctions
-// & SignLimitOrderFunctions
-// & PostLimitOrderFunctions
+// type BuildOTCOrderFunctions
+// & SignOTCOrderFunctions
+// & PostOTCOrderFunctions
 
-const limitOrderSDK = constructPartialSDK(
+const OTCOrderSDK = constructPartialSDK(
   {
     chainId: 1,
     fetcher,
     contractCaller,
   },
-  constructBuildLimitOrder,
-  constructSignLimitOrder,
-  constructPostLimitOrder
+  constructBuildOTCOrder,
+  constructSignOTCOrder,
+  constructPostOTCOrder
 );
 
 const DAI = '0x6B175474E89094C44Da98b954EedeAC495271d0F';
@@ -55,22 +56,22 @@ const orderInput = {
   makerAmount: (1e18).toString(10),
   takerAmount: (8e18).toString(10),
   maker: wallet.address,
+  taker: takerAccount,
 };
 
 async function run() {
-  const signableOrderData: SignableOrderData =
-    await limitOrderSDK.buildLimitOrder(orderInput);
-
-  const signature: string = await limitOrderSDK.signLimitOrder(
-    signableOrderData
+  const signableOrderData: SignableOrderData = await OTCOrderSDK.buildOTCOrder(
+    orderInput
   );
 
-  const orderToPostToApi: LimitOrderToSend = {
+  const signature: string = await OTCOrderSDK.signOTCOrder(signableOrderData);
+
+  const orderToPostToApi: OTCOrderToPost = {
     ...signableOrderData.data,
     signature,
   };
 
-  const newOrder = await limitOrderSDK.postLimitOrder(orderToPostToApi);
+  const newOrder = await OTCOrderSDK.postOTCOrder(orderToPostToApi);
   console.log(newOrder);
 }