Conversation
jmesharrison
approved these changes
Oct 7, 2025
MJordahn
reviewed
Oct 7, 2025
| train_loss.backward() | ||
| optimizer.step() | ||
|
|
||
| # Check that loss is finite and decreasing |
Collaborator
There was a problem hiding this comment.
No test for decreasing here currently
Collaborator
There was a problem hiding this comment.
This might fail for large learning rates though (decreasing check). Suggest either reducing learning rate or simply not checking for decreasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive testing infrastructure for the VBLL library, including automated CI setup, configuration files, fixtures, and documentation. The changes enable robust, reproducible, and flexible testing using pytest, and provide clear guidance for contributors on running and extending the test suite.
Testing Infrastructure and Automation
.github/workflows/ci.yml) to automatically run tests on pushes and pull requests tomain/masterbranches. The workflow sets up Python, installs dependencies (including PyTorch), and runs the test suite with pytest.run_tests.py) that provides a command-line interface for running the test suite with options for quick/unit/integration/benchmark tests, parallel execution, coverage, and optional GPU/JAX support.Test Suite Configuration and Fixtures
pytest.inito configure pytest: specifies test discovery patterns, verbosity, warning filters, and custom markers for slow, GPU, integration, and unit tests.tests/conftest.pywith a comprehensive set of fixtures for devices, seeds, batch sizes, sample data, and common parameter sets for classification and regression layers, supporting reproducible and parameterized tests.Documentation and Developer Guidance
tests/README.mddetailing test structure, categories, running instructions, coverage, benchmarks, and troubleshooting tips, guiding contributors on best practices for testing and extending the suite.README.mdwith instructions for installing test dependencies and running tests using pytest.Project Configuration
pyproject.tomlto includepytestas a development dependency, ensuring test requirements are managed via Poetry.tests/__init__.pyto mark the tests directory as a package.These changes collectively establish a solid foundation for automated and manual testing, improving code quality and maintainability.