Skip to content

Fix: Added retry and time delay to nats_fixture.go in video-upload and video-recombiner to fix flaky github actions tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vchen7629 merged 2 commits into from
Apr 15, 2026
Merged

Fix: Added retry and time delay to nats_fixture.go in video-upload and video-recombiner to fix flaky github actions tests #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5fc2d6
fix(ci): added missing video-status path filter
Vchen7629 Apr 15, 2026
a3ae570
fix(backend): added retry to nats_fixture.go in video-upload and vide…
Vchen7629 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
transcoder_worker: ${{ steps.changes.outputs.transcoder_worker }}
video_recombiner: ${{ steps.changes.outputs.video_recombiner }}
video_upload: ${{ steps.changes.outputs.video_upload }}
video_status: ${{ steps.changes.outputs.video_status }}
steps:
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
Expand Down
7 changes: 6 additions & 1 deletion backend/video-recombiner/internal/test/nats_fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package test
import (
"context"
"testing"
"time"

"github.com/nats-io/nats.go"
"github.com/nats-io/nats.go/jetstream"
Expand All @@ -26,7 +27,11 @@ func SetupNats(t *testing.T) (jetstream.JetStream, *nats.Conn) {
url, err := container.ConnectionString(ctx)
require.NoError(t, err)

nc, err := nats.Connect(url)
nc, err := nats.Connect(url,
nats.RetryOnFailedConnect(true),
nats.MaxReconnects(10),
nats.ReconnectWait(200*time.Millisecond),
)
require.NoError(t, err)
t.Cleanup(nc.Close)

Expand Down
2 changes: 1 addition & 1 deletion backend/video-upload/cmd/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ func startTestServer(t *testing.T, kv jetstream.KeyValue) (*http.Server, *Config
t.Cleanup(func() { server.Shutdown(context.Background()) }) //nolint:errcheck

return server, cfg
}
}
2 changes: 1 addition & 1 deletion backend/video-upload/internal/handler/job_status_kv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ func updateJobStatusKV(ctx context.Context, jobID string, kv jetstream.KeyValue,
}

return nil
}
}
8 changes: 7 additions & 1 deletion backend/video-upload/internal/test/nats_fixtures.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package test
import (
"context"
"testing"
"time"

"github.com/nats-io/nats.go"
"github.com/nats-io/nats.go/jetstream"
Expand All @@ -26,7 +27,12 @@ func SetupNats(t *testing.T) (jetstream.JetStream, *nats.Conn) {
url, err := container.ConnectionString(ctx)
require.NoError(t, err)

nc, err := nats.Connect(url)
nc, err := nats.Connect(url,
nats.RetryOnFailedConnect(true),
nats.MaxReconnects(10),
nats.ReconnectWait(200*time.Millisecond),
)

require.NoError(t, err)
t.Cleanup(nc.Close)

Expand Down
Loading