Skip to content

fix(fs): scope ThreadRng to ensure future is Send in save_asset#93

Merged
VariableThe merged 1 commit into
mainfrom
fix/thread-rng-send
Jul 1, 2026
Merged

fix(fs): scope ThreadRng to ensure future is Send in save_asset#93
VariableThe merged 1 commit into
mainfrom
fix/thread-rng-send

Conversation

@VariableThe

Copy link
Copy Markdown
Owner

Scopes rand::thread_rng() inside a block so ThreadRng (which contains Rc<UnsafeCell<...>> and is not Send) is dropped before tokio::fs::write().await.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@VariableThe, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 057fb63e-be9f-4e59-ba68-2e65653f381b

📥 Commits

Reviewing files that changed from the base of the PR and between b9a2973 and 7f64c4a.

📒 Files selected for processing (1)
  • src-tauri/src/commands/fs.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/thread-rng-send

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@VariableThe VariableThe merged commit 09e492a into main Jul 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant