fix(fs): scope ThreadRng to ensure future is Send in save_asset#91
Merged
Conversation
Fixed 5 file(s) based on 5 unresolved review comments. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Contributor
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
future cannot be sent between threads safelycompilation error insave_assetcaused byrand::thread_rng()(which containsRc<UnsafeCell<...>>and is notSend) being held across an.awaitpoint.Changes
src-tauri/src/commands/fs.rs: Scopedrand::thread_rng()inside a block so theThreadRngis dropped beforetokio::fs::write().await, making the futureSend.SHORTCUT_VOICE_MEMOkey fromsettingsKeys.ts.Background
This branch (from
main) cherry-picks the image/asset support commits fromfeature/v0.5.9-image-support(save_asset, read_asset, image paste widget, etc.) and applies the Send fix on top. No memo/voice files are included.Closes the
future: Sendbuild error.