fix: remove duplicate update-ready toast listener#87
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughIn ChangesUpdate listener consolidation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes duplicate "Restart Now" toast notifications when an update is ready to install.
Root Cause
The backend emits both
update-status(withstatus: "ready") and the legacyupdate-readyevent when a download completes. The frontend had two separate listeners in App.tsx that each created the same toast — resulting in two "Restart Now" notifications stacked on top of each other.Change
onUpdateReadylistener in App.tsx (lines 80-89) and its cleanuponUpdateStatus/readyhandler (kept) now fires the toast once, as intendedSummary by CodeRabbit