fix(ci): sanitize release signing key before tauri build#84
Conversation
…ove trailing terminal prompt artifact (%) or URL encoding
|
Warning Review limit reached
Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow gains a Python-based step that strips trailing CI Signing Key Sanitization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 59-67: The Sanitize Tauri Signing Key step in the release workflow
is using Bash/POSIX syntax without an explicit shell, so the Windows runner may
execute it in PowerShell and fail. Update the sanitize step in release.yml to
force Bash by adding a shell setting, or rewrite the block for PowerShell, and
keep the logic aligned with the existing Sanitize Tauri Signing Key step so
tauri-action still receives TAURI_SIGNING_PRIVATE_KEY correctly.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f007bf85-bc41-4a96-a65a-151df9921c52
📒 Files selected for processing (3)
.github/workflows/release.ymlAUDIT_LOG.mdCHANGELOG.md
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. The agent generated fixes only for
Lines 57–62 - run: npm ci
- name: Sanitize Tauri Signing Key
+ shell: bash
env:
RAW_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }}
run: | |
…orm runner compatibility
Summary
Fixes base64 decoding failure (
Invalid symbol 37, offset 348) duringtauri buildasset bundling. Adds a workflow sanitization step to strip trailing terminal prompt EOF symbols (%) or URL-encoding artifacts before runningtauri-action.Summary by CodeRabbit