fix: center shortcut key pill '+' separator between key caps#64
fix: center shortcut key pill '+' separator between key caps#64VariableThe wants to merge 2 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 21 minutes and 3 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughUpdated the shortcut display in Settings to center the separator between key caps, and added matching audit/changelog entries for that UI change and the macOS window-state compensation removal. ChangesSettings shortcut layout and release notes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/Settings.tsx (1)
432-454: 🩺 Stability & Availability | 🟡 MinorRemove
React.Fragmentusage or importReact.The file currently uses
React.Fragmentat line 432 without importing theReactnamespace, which causes aReferenceError: React is not definedat runtime.Since
useStateanduseEffectare already imported directly, the most concise fix is to replaceReact.Fragmentwith JSX shorthand fragments (<>).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/Settings.tsx` around lines 432 - 454, The icon/shortcut rendering in Settings.tsx uses React.Fragment without a React namespace import, which will fail at runtime. Update the fragment usage inside the parts mapping to the JSX shorthand fragment syntax, or alternatively import React at the top of the file; the simplest fix is to replace React.Fragment in that render block so the component no longer depends on an undeclared React identifier.Source: Pipeline failures
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AUDIT_LOG.md`:
- Around line 5-24: The audit log has two top-level headings with the same
`2026-06-25` date, which triggers MD024 and reduces readability. Update the
`AUDIT_LOG.md` entries so there is only one `2026-06-25` heading, then place
both change notes beneath it or convert the second entry into a nested
bullet/subsection while keeping the existing content intact.
---
Outside diff comments:
In `@src/Settings.tsx`:
- Around line 432-454: The icon/shortcut rendering in Settings.tsx uses
React.Fragment without a React namespace import, which will fail at runtime.
Update the fragment usage inside the parts mapping to the JSX shorthand fragment
syntax, or alternatively import React at the top of the file; the simplest fix
is to replace React.Fragment in that render block so the component no longer
depends on an undeclared React identifier.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6e06bfaa-a931-4aac-b8d8-8f41db808dd3
📒 Files selected for processing (3)
AUDIT_LOG.mdCHANGELOG.mdsrc/Settings.tsx
The renderShortcutDisplay function grouped each key cap and the '+' to its right in a wrapper <span> with justify-content: space-evenly, making the '+' appear closer to the left key cap. Flattened to React.Fragment siblings in a flex row with justify-content: center and gap: 4px so the '+' sits independently centered. Also adds CHANGELOG and AUDIT_LOG entries for this fix and the previously merged macOS window shift compensation removal.
0ca6644 to
b0bcb6f
Compare
d237d20 to
f968376
Compare
Summary
Fixes the '+' symbol in the shortcut display being visually closer to the left key cap due to being grouped in the same
<span>wrapper withjustify-content: space-evenly.Fix: Flattened to
<React.Fragment>siblings in a flex row withjustify-content: centerandgap: 4px. Each '+' is now independently centered with equal spacing on both sides.Also adds missing CHANGELOG.md and AUDIT_LOG.md entries for this fix and the previously merged macOS window shift compensation removal (PR #62).
Summary by CodeRabbit