Skip to content

fix: center shortcut key pill '+' separator between key caps#64

Closed
VariableThe wants to merge 2 commits into
mainfrom
fix/shortcut-pill-centering
Closed

fix: center shortcut key pill '+' separator between key caps#64
VariableThe wants to merge 2 commits into
mainfrom
fix/shortcut-pill-centering

Conversation

@VariableThe

@VariableThe VariableThe commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the '+' symbol in the shortcut display being visually closer to the left key cap due to being grouped in the same <span> wrapper with justify-content: space-evenly.

Fix: Flattened to <React.Fragment> siblings in a flex row with justify-content: center and gap: 4px. Each '+' is now independently centered with equal spacing on both sides.

Also adds missing CHANGELOG.md and AUDIT_LOG.md entries for this fix and the previously merged macOS window shift compensation removal (PR #62).

Summary by CodeRabbit

  • Bug Fixes
    • Fixed macOS frameless windows shifting down after restart, so window position now restores more reliably.
    • Improved the settings shortcut display so the “+” separator is centered neatly between keys.
  • Chores
    • Updated release notes and audit records with the latest fixes.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@VariableThe, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 21 minutes and 3 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 98c55e83-2113-4766-a455-789196e4e763

📥 Commits

Reviewing files that changed from the base of the PR and between 0ca6644 and f968376.

📒 Files selected for processing (3)
  • AUDIT_LOG.md
  • CHANGELOG.md
  • src/Settings.tsx
📝 Walkthrough

Walkthrough

Updated the shortcut display in Settings to center the separator between key caps, and added matching audit/changelog entries for that UI change and the macOS window-state compensation removal.

Changes

Settings shortcut layout and release notes

Layer / File(s) Summary
Shortcut display layout
src/Settings.tsx
The shortcut token row centers its contents with gap spacing, removes per-token span wrappers, and simplifies the + separator styling.
Release note entries
AUDIT_LOG.md, CHANGELOG.md
The audit log and changelog add June 25 and v0.5.4 entries for the macOS window-state compensation removal and the centered shortcut separator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped past keys with a joyful grin,
And centered the plus where it belongs within.
The changelog rustles, the audit log sings,
While tidy little shortcuts do tidy little things.
🌿✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main UI fix: centering the shortcut '+' separator between key caps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/shortcut-pill-centering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/Settings.tsx (1)

432-454: 🩺 Stability & Availability | 🟡 Minor

Remove React.Fragment usage or import React.

The file currently uses React.Fragment at line 432 without importing the React namespace, which causes a ReferenceError: React is not defined at runtime.

Since useState and useEffect are already imported directly, the most concise fix is to replace React.Fragment with JSX shorthand fragments (<>).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/Settings.tsx` around lines 432 - 454, The icon/shortcut rendering in
Settings.tsx uses React.Fragment without a React namespace import, which will
fail at runtime. Update the fragment usage inside the parts mapping to the JSX
shorthand fragment syntax, or alternatively import React at the top of the file;
the simplest fix is to replace React.Fragment in that render block so the
component no longer depends on an undeclared React identifier.

Source: Pipeline failures

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@AUDIT_LOG.md`:
- Around line 5-24: The audit log has two top-level headings with the same
`2026-06-25` date, which triggers MD024 and reduces readability. Update the
`AUDIT_LOG.md` entries so there is only one `2026-06-25` heading, then place
both change notes beneath it or convert the second entry into a nested
bullet/subsection while keeping the existing content intact.

---

Outside diff comments:
In `@src/Settings.tsx`:
- Around line 432-454: The icon/shortcut rendering in Settings.tsx uses
React.Fragment without a React namespace import, which will fail at runtime.
Update the fragment usage inside the parts mapping to the JSX shorthand fragment
syntax, or alternatively import React at the top of the file; the simplest fix
is to replace React.Fragment in that render block so the component no longer
depends on an undeclared React identifier.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6e06bfaa-a931-4aac-b8d8-8f41db808dd3

📥 Commits

Reviewing files that changed from the base of the PR and between 6683b5c and 0ca6644.

📒 Files selected for processing (3)
  • AUDIT_LOG.md
  • CHANGELOG.md
  • src/Settings.tsx

Comment thread AUDIT_LOG.md
The renderShortcutDisplay function grouped each key cap and the '+'
to its right in a wrapper <span> with justify-content: space-evenly,
making the '+' appear closer to the left key cap. Flattened to
React.Fragment siblings in a flex row with justify-content: center
and gap: 4px so the '+' sits independently centered.

Also adds CHANGELOG and AUDIT_LOG entries for this fix and the
previously merged macOS window shift compensation removal.
@VariableThe VariableThe force-pushed the fix/shortcut-pill-centering branch from 0ca6644 to b0bcb6f Compare June 25, 2026 12:02
@VariableThe VariableThe force-pushed the fix/shortcut-pill-centering branch from d237d20 to f968376 Compare June 25, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant