Skip to content

fix: hide tauri window-state.json from the note list#48

Merged
VariableThe merged 1 commit into
mainfrom
fix/hide-window-state
Jun 23, 2026
Merged

fix: hide tauri window-state.json from the note list#48
VariableThe merged 1 commit into
mainfrom
fix/hide-window-state

Conversation

@VariableThe

@VariableThe VariableThe commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Ignores tauri's window-state files in the note loader so they do not show up in the UI.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where temporary application state files were being incorrectly processed and displayed alongside your notes in the notes list.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 376100e1-e69d-43ed-bbf7-bee9cc03d8c5

📥 Commits

Reviewing files that changed from the base of the PR and between fe7e858 and 396baee.

📒 Files selected for processing (1)
  • src-tauri/src/commands/fs.rs

📝 Walkthrough

Walkthrough

In walk_dir, two filenames (window-state.json and .window-state) are now explicitly excluded via early continue statements, preventing those window-state artifact files from being read and processed as notes.

Changes

walk_dir window-state filter

Layer / File(s) Summary
Skip window-state filenames in walk_dir
src-tauri/src/commands/fs.rs
walk_dir extracts each entry's filename and skips entries named window-state.json or .window-state before any note-loading logic runs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Hippity-hop through the folder tree,
But window-state.json? That's not for me!
I skip .window-state with a flick of my ear,
No phantom JSON notes shall appear.
Only real notes in my burrow, oh dear! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: preventing Tauri's window-state.json files from appearing in the note list by filtering them during filesystem traversal.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/hide-window-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@VariableThe VariableThe merged commit 5607311 into main Jun 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant