Skip to content

Fix agent rule violations #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VariableThe merged 2 commits into from
Jun 20, 2026
Merged

Fix agent rule violations #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
375b5a7
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] Jun 20, 2026
8c43d03
fix: resolve tasks toggle listener leak and rename menu button
VariableThe Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 49 additions & 26 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/MainActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export function MainActionMenu() {
fontSize: 14,
}}
>
Reminders
Tasks
</button>
<button
onClick={() => {
Expand Down
7 changes: 6 additions & 1 deletion src/components/RemindersPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,19 @@ export const RemindersPage: React.FC<RemindersPageProps> = ({

React.useEffect(() => {
let timeoutId: ReturnType<typeof setTimeout>
let isMounted = true
const scheduleNext = () => {
timeoutId = setTimeout(() => {
if (!isMounted) return
setNow(Date.now())
scheduleNext()
}, 10000) // update every 10s for better responsiveness
}
scheduleNext()
return () => clearTimeout(timeoutId)
return () => {
isMounted = false
clearTimeout(timeoutId)
}
}, [])

return (
Expand Down
Loading
Loading