Add new node-type FMU#1017
Open
riteshk001 wants to merge 8 commits into
Open
Conversation
Signed-off-by: Ritesh.K <riteshkarki6@gmail.com> Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Ritesh.K <riteshkarki6@gmail.com> Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Ritesh.K <riteshkarki6@gmail.com> Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Ritesh.K <riteshkarki6@gmail.com> Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Ritesh.K <riteshkarki6@gmail.com> Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>
Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>
stv0g
requested changes
Jul 9, 2026
stv0g
left a comment
stv0g
left a comment
Contributor
There was a problem hiding this comment.
Nice work. Its great to see FMI support landing in VILLAS
| @@ -0,0 +1,61 @@ | |||
| # SPDX-FileCopyrightText: 2014-2023 Institute for Automation of Complex Power Systems, RWTH Aachen University | |||
| @@ -0,0 +1,26 @@ | |||
| # CMakeLists.txt. | |||
| # | |||
| # Author: Ritesh Karki | |||
Contributor
There was a problem hiding this comment.
Please add a contact mail address
| @@ -0,0 +1,7 @@ | |||
| # yaml-language-server: $schema=http://json-schema.org/draft-07/schema | |||
| # SPDX-FileCopyrightText: 2014-2023 Institute for Automation of Complex Power Systems, RWTH Aachen University | |||
| }, | ||
| fmu_node = { | ||
| type = "fmu" | ||
| # Path to fmu file |
Contributor
There was a problem hiding this comment.
Suggested change
| # Path to fmu file | |
| # Path to the FMU file (.fmu) |
| # Path to fmu file | ||
| fmu_path = "/workspaces/node/fmu_temp/asine.fmu" | ||
| fmu_unpack_path = "/workspaces/node/fmu_temp/fmu_asine" | ||
| fmu_writefirst = true |
Contributor
There was a problem hiding this comment.
Suggested change
| fmu_writefirst = true | |
| fmu_write_first = true |
| type = "file" | ||
| # format = "csv" | ||
| uri = "/workspaces/node/fmu_temp/output.dat" | ||
| out = { |
Contributor
There was a problem hiding this comment.
Is this empty section required?
| callbacks.log_level = jm_log_level_info; | ||
| callbacks.context = nullptr; | ||
| context = fmi_import_allocate_context(&callbacks); | ||
|
|
Contributor
There was a problem hiding this comment.
I believe at least the callbacks can be initialized in the constructor?
|
|
||
| struct stat sb; | ||
| if (stat(unpack_path, &sb) != 0) | ||
| std::cerr << "The unpack path is invalid" << std::endl; |
Contributor
There was a problem hiding this comment.
Dont log via iostreams. Use the existing logging infrastructure.
| return Node::prepare(); | ||
| } | ||
|
|
||
| int FmuNode::check() { return Node::check(); } |
| while (hasInputs && (writingTurn || currentTime >= stopTime)) { | ||
| pthread_cond_wait(&cv, &mutex); | ||
| } | ||
| double targetTime = currentTime + stepSize; |
Contributor
There was a problem hiding this comment.
I think this not executing the FMU using a real-time scale?
Can you elaborate a bit how this node-type is indentend to be used?
E.g. does it expect periodic input data to proceed its internal time?
How does the internal time related to the real time?
Do we already have a PR for the node-type? I think this deserves some explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@al3xa23
New node type implementation based on Functional Mock-up Interface (FMI 3.0). Currently supports Co-Simulation. Functionality can be further extended to include Model Exchange simulation too.