Skip to content

Remove trailing commas in example JSON metadata#43

Merged
Scottan merged 1 commit intomainfrom
example-json-typo
Apr 16, 2026
Merged

Remove trailing commas in example JSON metadata#43
Scottan merged 1 commit intomainfrom
example-json-typo

Conversation

@martinherrerias
Copy link
Copy Markdown
Contributor

json.load doesn't like the trailing commas on the last two list elements of the example JSON metadata

`json.load` doesn't like the trailing commas on the last two list elements of the example JSON metadata
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 14, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/UoMResearchIT/programming_with_python/compare/md-outputs..md-outputs-PR-43

The following changes were observed in the rendered markdown documents:

 02-dictionaries.md | 4 ++--
 md5sum.txt         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-05-14 09:56:59 +0000

github-actions bot pushed a commit that referenced this pull request May 14, 2025
Copy link
Copy Markdown
Collaborator

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure this is true in more recent versions, but it looks neater without the comma so this is fine to be merged.

@Scottan Scottan merged commit 03fc1c6 into main Apr 16, 2026
3 checks passed
@Scottan Scottan deleted the example-json-typo branch April 16, 2026 09:17
github-actions bot pushed a commit that referenced this pull request Apr 16, 2026
Auto-generated via `{sandpaper}`
Source  : 03fc1c6
Branch  : main
Author  : scottan <33283688+Scottan@users.noreply.github.com>
Time    : 2026-04-16 09:17:22 +0000
Message : Merge pull request #43 from UoMResearchIT/example-json-typo

Remove trailing commas in example JSON metadata
github-actions bot pushed a commit that referenced this pull request Apr 16, 2026
Auto-generated via `{sandpaper}`
Source  : c9de1d0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-04-16 09:19:05 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 03fc1c6
Branch  : main
Author  : scottan <33283688+Scottan@users.noreply.github.com>
Time    : 2026-04-16 09:17:22 +0000
Message : Merge pull request #43 from UoMResearchIT/example-json-typo

Remove trailing commas in example JSON metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants