Skip to content

feat: resident profile PR 3#1099

Closed
CK-7vn wants to merge 1 commit intoCK-7vn/total-refactor-resident-profile-2from
CK-7vn/total-refactor-resident-profile-3
Closed

feat: resident profile PR 3#1099
CK-7vn wants to merge 1 commit intoCK-7vn/total-refactor-resident-profile-2from
CK-7vn/total-refactor-resident-profile-3

Conversation

@CK-7vn
Copy link
Copy Markdown
Member

@CK-7vn CK-7vn commented Mar 2, 2026

Pre-Submission PR Checklist

  • No debug/console/fmt.Println statements
  • Unnecessary development comments removed
  • All acceptance criteria verified
  • Functions according to ticket specifications
  • Tested manually where applicable
  • Branch rebased with latest main
  • No business logic exists within the database layer

Description of the change

This is the Resident Profile PR #3

Adds completed programs cards, collapsible incomplete enrollments table, and historical notes section to the Resident Profile page.

Requirements Covered

  • 602 (Completed Programs -- section displays successfully finished programs)
  • 603 (Completed Programs -- program name and class name display)
  • 604 (Completed Programs -- completion date displays correctly)
  • 605 (Completed Programs -- sessions attended of total shows)
  • 606 (Incomplete Enrollments -- section is collapsible)
  • 607 (Incomplete Enrollments -- shows withdrawn and dropped enrollments)
  • 608 (Incomplete Enrollments -- status badge displays Withdrawn, Dropped, or other statuses)
  • 609 (Incomplete Enrollments -- enrolled and ended dates display)
  • 663 (Empty States -- empty completed programs shows appropriate message)
  • 664 (Empty States -- empty notes section shows appropriate message)
  • 668 (Deactivated -- Add Note button is hidden for deactivated residents)

*Deferred to final PR -- requires backend changes:

  • 610-613: Historical notes component built with empty state and Add Note button (stubbed). Backend needs: notes migration, model, CRUD endpoints (GET/POST /api/users/{id}/notes)

Screenshot(s)

PR Resident Profile additions

image image

Redesign Resident Profile Relevant

image image

Additional context

  • Incomplete enrollments filter uses startsWith('Incomplete:') to catch all incomplete statuses (Withdrawn, Dropped, Segregated, Failed to Complete, Transfered)
  • Status badge strips "Incomplete: " prefix for cleaner display
  • Incomplete enrollments section renders nothing when array is empty (no empty state card)
  • HistoricalNotes component accepts a typed notes array and isDeactivated prop -- ready to wire to real endpoint once backend exists

@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-2 branch from 1439867 to ab5825b Compare March 5, 2026 22:04
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-3 branch from 252b5b1 to df26fc8 Compare March 5, 2026 22:04
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-2 branch 2 times, most recently from 15d4f98 to 086cbad Compare March 7, 2026 06:38
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-3 branch from df26fc8 to 34acd14 Compare March 7, 2026 06:38
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-2 branch from 086cbad to e9b920a Compare March 9, 2026 20:11
@CK-7vn CK-7vn requested a review from a team as a code owner March 9, 2026 20:11
@CK-7vn CK-7vn requested review from corypride and removed request for a team March 9, 2026 20:11
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-2 branch 2 times, most recently from 086cbad to 8a2651e Compare March 12, 2026 18:27
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-3 branch from 34acd14 to aa4349e Compare March 12, 2026 18:28
Copy link
Copy Markdown
Contributor

@corypride corypride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-2 branch from 8a2651e to 2cee8d2 Compare March 24, 2026 15:32
@CK-7vn CK-7vn force-pushed the CK-7vn/total-refactor-resident-profile-3 branch from aa4349e to 33e23f3 Compare March 24, 2026 15:32
@CK-7vn CK-7vn closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants