feat: support and audit tabs for class detail page#1095
feat: support and audit tabs for class detail page#1095CK-7vn merged 54 commits intoCK-7vn/total-refactorfrom
Conversation
cc8d6d3 to
2775eed
Compare
b25ee52 to
9170257
Compare
2775eed to
202e7a8
Compare
9170257 to
77cc005
Compare
202e7a8 to
41e3174
Compare
bec2211 to
5ffed45
Compare
cf6606a to
53ca3c1
Compare
9dd506a to
8d8e1ae
Compare
carddev81
left a comment
There was a problem hiding this comment.
@CK-7vn I did not complete my review of this PR because this branch of code does not contain the latest changes from total_refactor branch (rebase is needed)--missing (program details fac admin version with breadcrumbs at top. Please rebase this branch to contain all of these changes, I want to make sure we don't break anything along the way and not have to revisit completed work. Also, I noticed that toast messages were flagged in other PRs for being displayed at the top and green--figma displays them at the bottom, i think maybe that the fixes you made are not here.
Other issues that I found while reviewing
- Duration metric card is not displaying correct schedule--notice start date (Start date set was sept 1, but displays the last day of september)
- Metric Cards (do not match the size of figma also font sizes do not match)
- Focus ring on Scheduled button is black but figma doesn't have a focus ring, you can remove this entirely
- when creating an instructor/room it does not auto select the instructor/room
- toast messages are appearing at the top and are green in color, figma appears at bottom and just bolded.
The plan is to completely review the design of Class Details since this contains all the previously reviewed design changes and check all functionality.
3f93d5b to
739b88c
Compare
e7818d5 to
dc0584a
Compare
bcfa395 to
0f1db52
Compare
5dd576b to
6a3c809
Compare
3d8bef3 to
adc73aa
Compare
carddev81
left a comment
There was a problem hiding this comment.
@CK-7vn I did another partial review, can you please fix all my findings below and please compare figma to this PRs design...only because I was finding a lot of differences between the two. I thought these findings may have been flagged before?
- Duration card at top doesn't display correct information when class has no end date (I liked your previous format better, it wasn't formated as an SQL date--question for @calisio )
- Duration card at top displays - when there is an end date, should be the word 'to'
- When clicking the Schedule tab Duration information doesn't match figma (also should the date be in this format @calisio , figured it would be more user friendly--same goes for all duration information cards not just this one?)
- Change status modal
- when opening the modal the the select box isn't focused as it is in the figma
- spacing between 'New Status' and select box doesn't match
- Update Status button is disabled
Target status modal
Current status modal
- When deleting a class it does not delete, it still shows up in the classes list like it was not deleted
- Within Edit class modal spacing between label and form input needs to be less of a gap
- Noticed that Edit class is missing an entire piece within the schedule (also noticed there is no astrisks)
Target schedule (Edit Class Modal)
Current schedule (Edit Class Modal)
- Sessions tab is unresponsive and not populating. It almost seems as if there is an infinite loop or there is a long running task here
Wanted to get some more work out to you so I don't hold you up. These are just some of my findings. Please double check to make sure everything is working correctly?
carddev81
left a comment
There was a problem hiding this comment.
@CK-7vn Issues have reappeared again, not sure if you rebased again? The breadcrumbs and spacing from total refactor are missing again. I had to stop reviewing because we are out of sync with total_refactor and I was finding the same issues as before? Not sure what happened in this last push with the request of changes.
- Same issue is appearing as before with the schedule in the Duration metrics card see image below. Also since you are fixing this issue, might as well spell the entire month name out? Your choice)
- Same issue exists that I found in the second review--Sessions tab when clicking on it still locks up and doesn't populate with info from classes that I created. Let me know if you need me to take a video of this and I'll send it your way--I'm unable to review it to make sure functionality is good and to do my spot checking of the ui.
- At 'Risk Tab' is not displaying the number in parentheses.
Please spot check current UI with target figmas.
416e311 to
087f0d9
Compare
|
@CK-7vn 'Program Details' in this branch still not matching CK7_/total_refactor see below comparison--rebasing issue, not sure what else? Breadcrumbs were fixed but spacing issue exists still. |
|
@CK-7vn Neither cancelling a class or completing a class completes/cancels enrolled residents, the process should do either or based on what status it is changed too. I tested the change class status modal functionality. Residents enrolled stay as enrolled.
|
9b672f5 to
9bdd066
Compare



Add Support tab with at-risk resident detection (attendance below 75% or consecutive absences) and Audit tab with class history timeline. Completes all 6 class detail tabs.
Pre-Submission PR Checklist
Description of the change
Adds the final two tabs — Support and Audit — to the class detail page, completing all 6 tabs.
Support Tab (SupportTab.tsx)
Audit Tab (AuditTab.tsx)
index.tsx