Skip to content

New config format#550

Open
Universal-Omega wants to merge 8 commits intomainfrom
configs
Open

New config format#550
Universal-Omega wants to merge 8 commits intomainfrom
configs

Conversation

@Universal-Omega
Copy link
Owner

@Universal-Omega Universal-Omega commented Feb 4, 2026

Summary by CodeRabbit

  • Documentation

    • Updated all configuration documentation to reference new DPL* global variable names instead of legacy nested DplSettings format.
  • Refactor

    • Replaced nested DplSettings configuration object with individual DPL* global variables for improved accessibility.
    • Maintained backward compatibility with legacy DplSettings configuration.
    • Updated internal codebase to use centralized configuration constants throughout.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • ✅ Full review completed - (🔄 Check again to review again)
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch configs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@includes/Config.php`:
- Around line 20-83: buildConfigFromGlobalsAndLegacy currently writes legacy
values under the old legacy keys and lets legacy override new globals; change
the lookup order and the keys used: in the foreach over $map check
$globalConfig->has($newGlobalName) first and if present set
$settings[$newGlobalName] = $globalConfig->get($newGlobalName); otherwise if
isset($legacySettings[$key]) set $settings[$newGlobalName] =
$legacySettings[$key] and mark $usedLegacy = true. Update references to use the
$newGlobalName (ConfigNames::...) as the settings array key so
Config::get(ConfigNames::…) sees legacy fallbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant