fix(types): add missing port property to StartOptions interface#6078
Open
thecaptain789 wants to merge 1 commit intoUnitech:masterfrom
Open
fix(types): add missing port property to StartOptions interface#6078thecaptain789 wants to merge 1 commit intoUnitech:masterfrom
thecaptain789 wants to merge 1 commit intoUnitech:masterfrom
Conversation
The port configuration property is defined in lib/API/schema.json but was missing from the TypeScript type definitions in types/index.d.ts. This adds the port property to the StartOptions interface to match the runtime behavior documented in the schema. Fixes Unitech#6045
|
MiloBot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
portconfiguration property is defined inlib/API/schema.jsonbut was missing from the TypeScript type definitions intypes/index.d.ts.This PR adds the
portproperty to theStartOptionsinterface to match the runtime behavior documented in the schema.Schema Reference
From
lib/API/schema.json:Changes
port?: numberproperty toStartOptionsinterfaceRelated Issue
Fixes #6045