Skip to content

fix(types): add missing port property to StartOptions interface#6078

Open
thecaptain789 wants to merge 1 commit intoUnitech:masterfrom
thecaptain789:fix/add-port-to-start-options-typings
Open

fix(types): add missing port property to StartOptions interface#6078
thecaptain789 wants to merge 1 commit intoUnitech:masterfrom
thecaptain789:fix/add-port-to-start-options-typings

Conversation

@thecaptain789
Copy link

Description

The port configuration property is defined in lib/API/schema.json but was missing from the TypeScript type definitions in types/index.d.ts.

This PR adds the port property to the StartOptions interface to match the runtime behavior documented in the schema.

Schema Reference

From lib/API/schema.json:

"port": {
  "type": "number",
  "docDescription": "Shortcut to inject a PORT environment variable"
}

Changes

  • Added port?: number property to StartOptions interface
  • Added JSDoc comment matching the schema description

Related Issue

Fixes #6045

The port configuration property is defined in lib/API/schema.json but was
missing from the TypeScript type definitions in types/index.d.ts.

This adds the port property to the StartOptions interface to match the
runtime behavior documented in the schema.

Fixes Unitech#6045
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


MiloBot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In StartOptions typings, the port configuration is missing

2 participants