Skip to content

[TS] Improve performance of EtsHierarchy #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lipen merged 1 commit into from
Aug 6, 2025
Merged

[TS] Improve performance of EtsHierarchy #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion usvm-ts/src/main/kotlin/org/usvm/util/EtsHierarchy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
classes
.groupBy { it.signature }
.mapValues { it.value.single() }
.let { HashMap(it) }
}
.let { HashMap(it) }
}

private val ancestors: Map<EtsClass, Set<EtsClass>> by lazy {
Expand Down Expand Up @@ -111,7 +113,7 @@

if (etsClassType.isResolved()) {
val signature = (etsClassType as EtsClassType).signature.copy(name = typeName)
return suitableClasses[signature]?.let { hashSetOf(it) } ?: emptySet()
return suitableClasses[signature]?.let { setOf(it) } ?: emptySet()

Check warning

Code scanning / detekt

Use `orEmpty()` call instead of `?:` with empty collection factory methods Warning

This '?: emptySet()' can be replaced with 'orEmpty()' call
}

return suitableClasses.values
Expand Down