Skip to content

Add time profiling in UDebugProfileObserver #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tochilinak merged 4 commits into from
Jun 19, 2025
Merged

Add time profiling in UDebugProfileObserver #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53a0a09
add time profiling
tochilinak Jun 19, 2025
1bd6e37
Timing in nanoseconds
tochilinak Jun 19, 2025
24f1fb9
detekt fix
tochilinak Jun 19, 2025
00faa32
detekt fix
tochilinak Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 108 additions & 24 deletions usvm-core/src/main/kotlin/org/usvm/statistics/UDebugProfileObserver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,43 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St
* Add padding to instructions in profiler report.
* */
val padInstructionEnd: Int = 0,
)
/**
* Profile time spent on each instruction.
* */
val profileTime: Boolean = true,
/**
* Profile number of forks on each instruction.
* */
val profileForks: Boolean = true,
val timeFormat: TimeFormat = TimeFormat.Microseconds,
) {
init {
require(!profileTime || momentOfUpdate == MomentOfUpdate.BeforeStep) {
"Time profiling in now supported only if momentOfUpdate in BeforeStep"
}
}
}

protected val instructionStats = hashMapOf<Statement, MutableMap<StateId, StatsCounter>>()
protected val methodCalls = hashMapOf<Method, MutableMap<StateId, StatsCounter>>()

private val stackTraceTracker = StackTraceTracker<Statement, Method, State>(statementOperations)
private val stackTraceTracker = StackTraceTracker(statementOperations)
private val stackTraces = hashMapOf<TrieNode<Statement, *>, MutableMap<StateId, StatsCounter>>()
private val forksCount = hashMapOf<TrieNode<Statement, *>, MutableMap<StateId, StatsCounter>>()
private val instructionTime = hashMapOf<TrieNode<Statement, *>, MutableMap<StateId, StatsCounter>>()

private var lastPeekMoment = 0L
private var lastStackTrace: TrieNode<Statement, *>? = null

override fun onStatePeeked(state: State) {
if (profilerOptions.momentOfUpdate == MomentOfUpdate.BeforeStep) {
processStateUpdate(state)
if (profilerOptions.momentOfUpdate != MomentOfUpdate.BeforeStep) {
return
}

processStateUpdate(state)

if (profilerOptions.profileTime) {
lastPeekMoment = System.nanoTime()
}
}

Expand All @@ -100,6 +125,20 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St
processStateUpdate(it)
}
}

if (profilerOptions.momentOfUpdate == MomentOfUpdate.BeforeStep && profilerOptions.profileTime) {
val stackTrace = lastStackTrace
?: error("stackTraceAfterPeek should have been memorized")
incrementInstructionTime(parent, stackTrace, System.nanoTime() - lastPeekMoment)
}
}

private fun incrementInstructionTime(state: State, stackTrace: TrieNode<Statement, *>, time: Long) {
var st = stackTrace
while (true) {
instructionTime.increment(st, state, value = time)
st = st.parent() ?: break
}
}

private fun processStateUpdate(state: State) {
Expand All @@ -124,17 +163,18 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St
val fork = statementOperations.forkHappened(state, node)

var st = stackTraceTracker.getStackTrace(state, node.statement)
lastStackTrace = st
while (true) {
stackTraces.increment(st, state)
if (fork) forksCount.increment(st, state)
st = st.parent() ?: break
}
}

private fun <K> MutableMap<K, MutableMap<StateId, StatsCounter>>.increment(key: K, state: State) {
private fun <K> MutableMap<K, MutableMap<StateId, StatsCounter>>.increment(key: K, state: State, value: Long = 1L) {
val stateStats = this.getOrPut(key) { hashMapOf() }
val stats = stateStats.getOrPut(state.id) { StatsCounter() }
stats.increment()
stats.add(value)
}

private fun aggregateStackTraces(slice: StateId?): ProfileFrame<Statement, Method, State> {
Expand All @@ -143,36 +183,51 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St
}
return ProfileFrame(
inst = null,
total = -1,
self = -1,
totalSteps = -1,
selfSteps = -1,
totalForks = -1,
selfForks = -1,
totalTime = -1,
selfTime = -1,
children = children,
profilerOptions,
statementOperations,
)
}

private fun formatTime(time: Long): Long {
return when (profilerOptions.timeFormat) {
TimeFormat.Nanoseconds -> time
TimeFormat.Microseconds -> time / MICRO_IN_NANO
TimeFormat.Milliseconds -> time / MILLIES_IN_NANO
}
}

private fun computeProfileFrame(
slice: StateId?,
inst: Statement,
root: TrieNode<Statement, *>,
): ProfileFrame<Statement, Method, State> {
val allNodeStats = stackTraces[root].orEmpty()
val allForkStats = forksCount[root].orEmpty()
val allTimeStats = instructionTime[root].orEmpty()
val children = root.children.mapValues { (i, node) -> computeProfileFrame(slice, i, node) }

val nodeStats = allNodeStats.sumOfSlice(slice)
val forkStats = allForkStats.sumOfSlice(slice)
val timeStats = allTimeStats.sumOfSlice(slice)

val selfStat = nodeStats - children.values.sumOf { it.total }
val selfStat = nodeStats - children.values.sumOf { it.totalSteps }
val selfForks = forkStats - children.values.sumOf { it.totalForks }
val selfTime = timeStats - children.values.sumOf { it.totalTime }
return ProfileFrame(
inst,
nodeStats,
selfStat,
forkStats,
selfForks,
totalSteps = nodeStats,
selfSteps = selfStat,
totalForks = forkStats,
selfForks = selfForks,
totalTime = formatTime(timeStats),
selfTime = formatTime(selfTime),
children,
profilerOptions,
statementOperations,
Expand All @@ -181,26 +236,36 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St

private class ProfileFrame<Statement, Method, State : UState<*, Method, Statement, *, *, *>>(
val inst: Statement?,
val total: Long,
val self: Long,
val totalSteps: Long,
val selfSteps: Long,
val totalForks: Long,
val selfForks: Long,
val totalTime: Long,
val selfTime: Long,
val children: Map<Statement, ProfileFrame<Statement, Method, State>>,
private val profilerOptions: Options,
private val statementOperations: StatementOperations<Statement, Method, State>,
) {
fun print(str: StringBuilder, indent: String) {
val sortedChildren = children.entries
.groupBy { statementOperations.getMethodOfStatement(it.key) }.entries
.sortedByDescending { entry -> entry.value.sumOf { it.value.total } }
.sortedByDescending { entry -> entry.value.sumOf { it.value.totalSteps } }

for ((method, inst) in sortedChildren) {
val total = inst.sumOf { it.value.total }
val self = inst.sumOf { it.value.self }
val total = inst.sumOf { it.value.totalSteps }
val self = inst.sumOf { it.value.selfSteps }
val totalForks = inst.sumOf { it.value.totalForks }
val selfForks = inst.sumOf { it.value.selfForks }
val methodRepr = statementOperations.printMethodName(method)
str.appendLine("$indent|__ $methodRepr | Steps $self/$total | Forks $selfForks/$totalForks")

str.append("$indent|__ $methodRepr | Steps $self/$total")
if (profilerOptions.profileForks) {
str.append(" | Forks $selfForks/$totalForks")
}
if (profilerOptions.profileTime) {
str.append(" | Time $selfTime/$totalTime")
}
str.appendLine()

val children = if (profilerOptions.printNonVisitedStatements) {
val allStatements = statementOperations.getAllMethodStatements(method)
Expand All @@ -212,10 +277,12 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St
} ?: let {
val emptyFrame = ProfileFrame(
childStmt,
total = 0L,
self = 0L,
totalSteps = 0L,
selfSteps = 0L,
totalForks = 0L,
selfForks = 0L,
totalTime = 0L,
selfTime = 0L,
emptyMap(),
profilerOptions,
statementOperations,
Expand All @@ -231,10 +298,16 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St

for ((i, child) in children) {
val instRepr = statementOperations.printStatement(i).padEnd(profilerOptions.padInstructionEnd)
val line = "$indent$INDENT$instRepr" +
" | Steps ${child.self}/${child.total}" +
" | Forks ${child.selfForks}/${child.totalForks}"

var line = "$indent$INDENT$instRepr | Steps ${child.selfSteps}/${child.totalSteps}"
if (profilerOptions.profileForks) {
line += " | Forks ${child.selfForks}/${child.totalForks}"
}
if (profilerOptions.profileTime) {
line += " | Time ${child.selfTime}/${child.totalTime}"
}
str.appendLine(line)

child.print(str, "$indent$INDENT$INDENT")
}
}
Expand Down Expand Up @@ -288,4 +361,15 @@ open class UDebugProfileObserver<Statement, Method, State : UState<*, Method, St
BeforeStep,
AfterStep,
}

enum class TimeFormat {
Milliseconds,
Microseconds,
Nanoseconds,
}

companion object {
private const val MICRO_IN_NANO = 1000L
private const val MILLIES_IN_NANO = 1_000_000L
}
}
2 changes: 2 additions & 0 deletions ...-python/usvm-python-main/src/main/kotlin/org/usvm/machine/utils/PyDebugProfileObserver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,7 @@ val pyDebugProfileObserver = UDebugProfileObserver(
profilerOptions = UDebugProfileObserver.Options(
momentOfUpdate = UDebugProfileObserver.MomentOfUpdate.AfterStep,
printNonVisitedStatements = true,
profileTime = false,
profileForks = false,
),
)