Skip to content

Add operator#277

Merged
CaelmBleidd merged 13 commits into
mainfrom
caelmbleidd/operators
May 22, 2025
Merged

Add operator#277
CaelmBleidd merged 13 commits into
mainfrom
caelmbleidd/operators

Conversation

@CaelmBleidd
Copy link
Copy Markdown
Member

@CaelmBleidd CaelmBleidd commented May 16, 2025 •
edited by Lipen
Loading

This PR adds support for Add (+) operator for TS interpreter.

@CaelmBleidd CaelmBleidd requested a review from Lipen May 16, 2025 13:51
github-advanced-security[bot]
github-advanced-security AI found potential problems May 16, 2025
View reviewed changes
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt Fixed
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt Fixed
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt Fixed
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt
// TODO support bigint

val fpValue = when {
return when {

Check warning

Code scanning / detekt

Braces do not comply with the specified policy Warning

Inconsistent braces, make sure all branches either have or don't have braces.
Comment thread usvm-ts/src/test/kotlin/org/usvm/util/Util.kt Fixed
Comment thread usvm-ts/src/test/kotlin/org/usvm/util/Util.kt Fixed
Lipen
Lipen reviewed May 16, 2025
View reviewed changes
Comment thread usvm-ts/src/test/resources/samples/operators/Add.ts Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/samples/operators/Or.kt Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/samples/operators/Neg.kt Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/samples/operators/Equality.kt Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/samples/operators/And.kt Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/samples/operators/Add.kt Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/util/Util.kt Outdated
@CaelmBleidd CaelmBleidd requested a review from Lipen May 19, 2025 13:46
Lipen
Lipen requested changes May 20, 2025
View reviewed changes
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/expr/ExprUtil.kt
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/expr/ExprUtil.kt Outdated
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt Outdated
Comment thread usvm-ts/src/main/kotlin/org/usvm/machine/operator/TsBinaryOperator.kt Outdated
Comment thread usvm-ts/src/test/kotlin/org/usvm/samples/FieldAccess.kt
Comment thread usvm-ts/src/test/kotlin/org/usvm/util/Util.kt Outdated
@CaelmBleidd CaelmBleidd requested a review from Lipen May 22, 2025 08:48
Lipen
Lipen approved these changes May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Lipen Lipen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good enough

@CaelmBleidd CaelmBleidd merged commit 96aa98e into main May 22, 2025
6 checks passed
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/operators branch May 22, 2025 09:27
Saloed pushed a commit that referenced this pull request Jun 2, 2025
@CaelmBleidd @Lipen
Add operator for USVM TS (#277)
5fef7a2 
---------

Co-authored-by: Konstantin Chukharev <lipen00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lipen Lipen Lipen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaelmBleidd @Lipen @github-advanced-security