Remove unused variable in decrease liquidity example#1110
Open
AlexScherbatyuk wants to merge 2 commits intoUniswap:mainfrom
Open
Remove unused variable in decrease liquidity example#1110AlexScherbatyuk wants to merge 2 commits intoUniswap:mainfrom
AlexScherbatyuk wants to merge 2 commits intoUniswap:mainfrom
Conversation
Remove the unused variable valueToPass in the liquidity modification call example. The liquidity decrease cases described above that involve TAKE_PAIR and CLEAR_OR_TAKE do not require providing additional ETH to the PositionManager. However, the presence of this variable in the call example creates misunderstanding and can lead to false assumptions.
|
@AlexScherbatyuk is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused variable valueToPass in the liquidity modification call example.
The liquidity decrease cases described above that involve TAKE_PAIR and CLEAR_OR_TAKE do not require providing additional ETH to the PositionManager.
However, the presence of this variable in the call example creates misunderstanding and can lead to false assumptions.
Description
Type(s) of changes
Motivation for PR
The presence of this variable in the call example creates misunderstanding and can lead to false assumptions
How Has This Been Tested?
Applicable screenshots
Follow-up PR