Skip to content

feat(perm-pool): Adding perm-pool deployments + fixing deploy-all path bug#148

Merged
SocksNFlops merged 2 commits into
mainfrom
socksnflops/adding-perm-pool-deployments
May 28, 2026
Merged

feat(perm-pool): Adding perm-pool deployments + fixing deploy-all path bug#148
SocksNFlops merged 2 commits into
mainfrom
socksnflops/adding-perm-pool-deployments

Conversation

@SocksNFlops

Copy link
Copy Markdown
Contributor

Pull Request

Description

  • Fixing path bug in UniversalRouter's deployer so that it properly finds PermissionsAdapterFactory
  • Adding Mainnet + Sepolia Deployments

Fixes # (issue)

How Has This Been Tested?

  • Deployed via deploy-cli and verified contracts on etherscan

Checklist:

Before deployment

  • 100% test and branch coverage
  • check slither for severe issues
  • fuzz and invariant tests (when applicable)
  • formal verification (when applicable)
  • deployment or upgrade scripts ready

After deployment

  • transfer ownership after deployments (when applicable)
  • complete upgrade (when applicable)
  • generate deployment/upgrade log files

Considerations

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run forge fmt and prettier to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

@SocksNFlops SocksNFlops self-assigned this May 28, 2026
@SocksNFlops SocksNFlops changed the title Socksnflops/adding perm pool deployments feat(perm-pool): Adding perm-pool deployments + fixing deploy-all path bug May 28, 2026
@SocksNFlops SocksNFlops merged commit 48b2205 into main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants