Skip to content

feat(briefcase): add deployers for permissioned-pool contracts#146

Merged
SocksNFlops merged 2 commits into
mainfrom
socksnflops/adding-perm-pool-support
May 28, 2026
Merged

feat(briefcase): add deployers for permissioned-pool contracts#146
SocksNFlops merged 2 commits into
mainfrom
socksnflops/adding-perm-pool-support

Conversation

@SocksNFlops

@SocksNFlops SocksNFlops commented May 27, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Adds the deploy infrastructure for the Permissioned Pools stack — new deployer libraries, task_template.json entries, and Deploy-all.s.sol wiring for:

Contract Source Notes
PermissionsAdapterFactory v4-periphery (hooks/permissionedPools/) runs=44444444, via_ir=true
PermissionedPositionManager v4-periphery (hooks/permissionedPools/) runs=500 (EIP-170 fit at 23,198 bytes)
PermissionedHooks v4-hooks-public (permissioned-pools/) runs=44444444, via_ir=false; salt-mined
UniversalRouter (V2.2.0) universal-router runs=1; adds permissionsAdapterFactory to RouterParameters (11th field)

Also adds Uniswap/v4-hooks-public as a new submodule.

Fixes # ECO-190

Upstream PRs landed before this

⚠️ On the diff size (61 files)

Only ~15 files are perm-pool specific. The remaining ~45 are src/briefcase/protocols/** regeneration catch-up: main's committed protocols/ had drifted from its own pinned submodule SHAs (UR BytesLib, Commands, UniswapX struct renames, etc.). Running create_briefcase.sh against the current pins materializes the catch-up. No upstream SHAs other than v4-hooks-public are bumped by this PR.

Sanity check from a clean main checkout: run ./script/util/create_briefcase.sh without any of this PR's changes — you'll see the same ~45 files of drift.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Before deployment

  • 100% test and branch coverage
  • check slither for severe issues
  • fuzz and invariant tests (when applicable)
  • formal verification (when applicable)
  • deployment or upgrade scripts ready

After deployment

  • transfer ownership after deployments (when applicable)
  • complete upgrade (when applicable)
  • generate deployment/upgrade log files

Considerations

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run forge fmt and prettier to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

@SocksNFlops SocksNFlops requested review from ericneil-sanc and gretzke and removed request for gretzke May 27, 2026 19:56
Comment thread script/deploy/tasks/task_template.json Outdated
@SocksNFlops SocksNFlops requested a review from gretzke May 28, 2026 15:32
@SocksNFlops SocksNFlops merged commit 53ac64b into main May 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants