Inverter gordon#56
Open
gordonzhang1 wants to merge 16 commits intomainfrom
Open
Conversation
Check FSM state, handle HV/EM conditions, and verify changes
Turns on inverter after checking state of car
…e in motorcontroller.c
DanBishara
requested changes
Nov 9, 2024
Contributor
DanBishara
left a comment
DanBishara
left a comment
There was a problem hiding this comment.
good work! mostly formatting errors, although I'll need to take a second look when you fix those. when you're done making the changes let me know I'll take another look and we can setup a time to test
DanBishara
requested changes
Nov 9, 2024
Contributor
DanBishara
left a comment
DanBishara
left a comment
There was a problem hiding this comment.
added more comments on turning on and off the MC
DanBishara
requested changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote CLI command to check state of Car, send CAN message to modify inverter EEPROM Parameter, check that parameter was set correctly.