Added testing capability using Github Actions#65
Open
pritamd47 wants to merge 28 commits into
Open
Conversation
Member
There was a problem hiding this comment.
Python build tarball is not being used by meta.yaml. We can leave the code as it is or can be deleted.
SanchitMinocha
requested changes
Oct 17, 2023
Member
SanchitMinocha
left a comment
SanchitMinocha
left a comment
There was a problem hiding this comment.
Good job1 It looks fantastic. Just minor comments/suggestions.
One Major Request:
Please add secrets read from os environment inside core/run_altimeter.py in case of test function.
Member
There was a problem hiding this comment.
will later add test assertion to verify automatically if tests have been passed or not. For now, it is ok.
Member
|
There is some error coming up while testing RAT for Gunnison. It seems like 'imerg' keyword is not there or might have been misspelled in the secrets file existing in os environ. Here is the snapshot of the error for your reference.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows running tests using GitHub Actions and pytest.