Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Node/Fastify toolchain by bumping a broad set of runtime and dev dependencies (Fastify ecosystem, MongoDB driver, ESLint, TypeScript ESLint, Prettier/plugins). It also changes the Yarn install strategy via .yarnrc.yml.
Changes:
- Bump various dependencies in
package.jsonand refreshyarn.lockaccordingly (Fastify plugins, auth libs, lint/format tooling). - Update the example MongoDB type annotation in
init-mongo.tscomments. - Switch Yarn’s
nodeLinkerfromnode-modulestopnpm.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
yarn.lock |
Large lockfile refresh to match dependency bumps and transitive changes. |
package.json |
Updates runtime/dev dependency versions (Fastify, MongoDB, ESLint, Prettier, etc.). |
src/plugins/init-mongo.ts |
Comment-only update to the example collection generic type. |
.yarnrc.yml |
Changes Yarn nodeLinker to pnpm, affecting install layout/behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "fastify": "^5.7.3", | ||
| "@fastify/swagger": "^9.7.0", | ||
| "@fastify/swagger-ui": "^5.2.5", | ||
| "@fastify/type-provider-typebox": "^6.1.0", |
There was a problem hiding this comment.
@fastify/type-provider-typebox was bumped to v6, but its lock entry now declares a peer dependency on the typebox package (not @sinclair/typebox). The repo currently depends on @sinclair/typebox, and there is no typebox package in the lockfile, so TypeScript resolution / runtime imports from the type-provider may fail. Either add/align the required typebox dependency and update imports accordingly, or keep @fastify/type-provider-typebox on a version compatible with @sinclair/typebox.
| "@fastify/type-provider-typebox": "^6.1.0", | |
| "@fastify/type-provider-typebox": "^5.0.0", |
| @@ -1,4 +1,4 @@ | |||
| nodeLinker: node-modules | |||
| nodeLinker: pnpm | |||
There was a problem hiding this comment.
Changing nodeLinker from node-modules to pnpm is a significant install/runtime behavior change and doesn’t match the PR’s stated scope of dependency bumps. If this is intentional, related docs/CI expectations should be updated and the change called out explicitly; if not, revert to node-modules to avoid unexpected breakage for contributors and pipelines.
No description provided.