[FEAT] 도서 상세 및 서재 액션에 독서 상태 응답 추가#267
Merged
Merged
Conversation
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Walkthrough이 PR은 도서 상세 조회 응답에 Changes도서 상세 및 서재 독서 상태 응답 추가
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/app/nook/library/controller/LibraryController.java`:
- Around line 58-60: The changeStatus handler in LibraryController is missing
request-body validation: add the `@Valid` annotation to the `@RequestBody` parameter
in the changeStatus method signature (public
ApiResponse<LibraryViewDto.BookStatusResponseDto> changeStatus(`@CurrentUser` User
user, `@Valid` `@RequestBody` ReadingStatusRequestDto requestDto)) and ensure
ReadingStatusRequestDto has appropriate validation annotations on its fields;
also import the correct Valid type (javax.validation.Valid or
jakarta.validation.Valid) so Spring triggers 4xx validation errors instead of
propagating invalid input to the service.
In `@src/test/java/app/nook/controller/book/BookControllerTest.java`:
- Line 93: The test currently asserts that the fields are missing
(jsonPath("$.result.readingStatus").doesNotExist()), which contradicts the API
contract that unregistered books should return bookShelfId=null and
readingStatus=null; update BookControllerTest assertions to explicitly expect
null for the JSON paths "$.result.readingStatus" and "$.result.bookShelfId" (and
the other occurrences around lines 112-113) by replacing the doesNotExist checks
with null-value assertions so the test requires the fields to be present with
null values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0f655c09-b472-41f8-8c25-5b57d9a54796
📒 Files selected for processing (10)
src/main/java/app/nook/book/converter/BookConverter.javasrc/main/java/app/nook/book/dto/BookResponseDto.javasrc/main/java/app/nook/book/service/BookService.javasrc/main/java/app/nook/library/controller/LibraryController.javasrc/main/java/app/nook/library/dto/LibraryViewDto.javasrc/main/java/app/nook/library/service/LibraryCommandService.javasrc/test/java/app/nook/book/service/BookServiceTest.javasrc/test/java/app/nook/controller/book/BookControllerTest.javasrc/test/java/app/nook/controller/library/LibraryControllerTest.javasrc/test/java/app/nook/library/service/LibraryServiceTest.java
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 작업 내용 요약
readingStatus추가bookId,bookShelfId,readingStatus추가📎 Issue 번호
✅ 작업 목록
📝 기타 참고사항
Summary by CodeRabbit
Release Notes