Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 98 additions & 99 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/middleware-code-coverage/lib/middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default async function({log, middlewareUtil, options={}, resources}) {
bodyParser.json({type: "application/json", limit: "50mb"}),
async (req, res) => {
const reportData = await reportCoverage(
req.body,
req.body ?? {},
config,
resources,
log
Expand Down
2 changes: 1 addition & 1 deletion packages/middleware-code-coverage/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"node": "^20.11.0 || >=22.0.0"
},
"dependencies": {
"body-parser": "^1.20.3",
"body-parser": "^2.2.2",
"istanbul-lib-coverage": "^3.2.2",
"istanbul-lib-instrument": "^6.0.3",
"istanbul-lib-report": "^3.0.1",
Expand Down
36 changes: 36 additions & 0 deletions packages/middleware-code-coverage/test/unit/lib/middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,42 @@ test("Coverage report request: no report data", async (t) => {
});
});

test("Coverage report request: no body", async (t) => {
const reportCoverageStub = sinon.stub();
const log = sinon.stub();
const instrumenterMiddleware = await esmock("../../../lib/middleware.js", {
"../../../lib/coverage-reporter.js": reportCoverageStub.returns(undefined)
});
const middleware = await instrumenterMiddleware({log, resources});

t.plan(2);

await new Promise((resolve) => {
const res = {
json() {
t.fail("should not be called.");
resolve();
},
err(message) {
t.is(reportCoverageStub.callCount, 1);
t.is(message, "No report data provided");
resolve();
}
};
const next = () => {
t.fail("should not be called.");
resolve();
};
middleware({
method: "POST",
url: "/.ui5/coverage/report",
headers: {
type: "application/json"
},
}, res, next);
});
});

test("Consume Coverage report request", async (t) => {
const serveStaticStub = sinon.stub();
const instrumenterMiddleware = await esmock.p("../../../lib/middleware.js", {
Expand Down